upleb.uk

Public git repos — served from a NIP-34 GRASP relay at git.upleb.uk

summaryrefslogtreecommitdiff
path: root/src/lib
diff options
context:
space:
mode:
authorDanConwayDev <DanConwayDev@protonmail.com>2025-08-07 17:49:02 +0100
committerDanConwayDev <DanConwayDev@protonmail.com>2025-08-07 17:49:02 +0100
commitfa7adf840ac2d78defee398a61b60888f615622a (patch)
tree4efe81ecf42b1f3e636f2e14c98175e4007f6d1b /src/lib
parent896267959bc9e436d7c5d2ee0ff8c8c088fc7274 (diff)
fix(send): refs not confirmed are usually accepted
having implemented 3b5c48f5a2a4b9be5d14baa8f5e801fefd5c1166, a ref pushed to refs/nostr/<event-id> on a github repo was accepted but was not confirmed
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/push.rs15
1 files changed, 3 insertions, 12 deletions
diff --git a/src/lib/push.rs b/src/lib/push.rs
index 0ee66cf..8cb0212 100644
--- a/src/lib/push.rs
+++ b/src/lib/push.rs
@@ -63,10 +63,9 @@ pub fn push_to_remote(
63 } 63 }
64 Ok(ref_updates_on_protocol) => { 64 Ok(ref_updates_on_protocol) => {
65 success = true; 65 success = true;
66 if remote_refspecs.len() == ref_updates_on_protocol.len() 66 if ref_updates_on_protocol
67 && ref_updates_on_protocol 67 .values()
68 .values() 68 .all(|error| error.is_none())
69 .all(|error| error.is_none())
70 { 69 {
71 if !failed_protocols.is_empty() { 70 if !failed_protocols.is_empty() {
72 term.write_line(format!("push: succeeded over {protocol}").as_str())?; 71 term.write_line(format!("push: succeeded over {protocol}").as_str())?;
@@ -444,14 +443,6 @@ pub async fn push_refs_and_generate_pr_or_pr_update_event(
444 "push: error sending commit data to {normalized_url}: {error}" 443 "push: error sending commit data to {normalized_url}: {error}"
445 ))?; 444 ))?;
446 responses.push((clone_url.clone(), Err(anyhow!(error.clone())))); 445 responses.push((clone_url.clone(), Err(anyhow!(error.clone()))));
447 } else if ref_updates.is_empty() {
448 term.write_line(&format!(
449 "push: error sending commit data to {normalized_url}: server didn't confirm acceptance"
450 ))?;
451 responses.push((
452 clone_url.clone(),
453 Err(anyhow!("server didn't confirm acceptance")),
454 ));
455 } else { 446 } else {
456 responses.push((clone_url.clone(), Ok(()))); 447 responses.push((clone_url.clone(), Ok(())));
457 term.write_line(&format!("push: commit data sent to {normalized_url}"))?; 448 term.write_line(&format!("push: commit data sent to {normalized_url}"))?;