fix(list): improve pr unsupport text

and show a more helpful message when proposal can be checked out
using the remote

2 files changed, 48 insertions, 7 deletions

diff --git a/src/bin/ngit/sub_commands/list.rs b/src/bin/ngit/sub_commands/list.rs
index c3c8c71..0083c91 100644
--- a/src/bin/ngit/sub_commands/list.rs
+++ b/src/bin/ngit/sub_commands/list.rs
@@ -206,13 +206,32 @@ pub async fn launch() -> Result<()> {
         {
             match Interactor::default().choice(
                 PromptChoiceParms::default()
-                    .with_prompt("this is new PR event kind which ngit doesnt yet support")
+                    .with_prompt(
+                        "this is new PR event kind which isn't supported in `ngit list` yet",
+                    )
                     .with_default(0)
-                    .with_choices(vec![
-                        // TODO enable checkout by fetching oids, creating / updating branch and
-                        // checking out
-                        "back to proposals".to_string(),
-                    ]),
+                    .with_choices(
+                        if [Kind::GitStatusOpen, Kind::GitStatusDraft].contains(&selected_status)
+                            && git_repo
+                                .get_first_nostr_remote_when_in_ngit_binary()
+                                .await
+                                .is_ok_and(|r| r.is_some())
+                        {
+                            vec![
+                                format!(
+                                    "I'll manually checkout the proposal at remote branch '{}'",
+                                    cover_letter
+                                        .get_branch_name_with_pr_prefix_and_shorthand_id()
+                                        .unwrap()
+                                ),
+                                // TODO fetch oids and follow similar logic for dealing with
+                                // conflcts as with patches below
+                                "back to proposals".to_string(),
+                            ]
+                        } else {
+                            vec!["back to proposals".to_string()]
+                        },
+                    ),
             )? {
                 0 => continue,
                 _ => {
@@ -251,7 +270,9 @@ pub async fn launch() -> Result<()> {
                     ]),
             )? {
                 0 => {
-                    println!("Some proposals are posted as patch without listing a parent commit\n");
+                    println!(
+                        "Some proposals are posted as patch without listing a parent commit\n"
+                    );
                     println!(
                         "they are not anchored against a particular state of the code base like a standard patch or a pull request can be\n"
                     );
diff --git a/src/lib/git/mod.rs b/src/lib/git/mod.rs
index d4bf2f5..b275b49 100644
--- a/src/lib/git/mod.rs
+++ b/src/lib/git/mod.rs
@@ -10,6 +10,7 @@ use nostr_sdk::{
     Tags,
     hashes::{Hash, sha1::Hash as Sha1Hash},
 };
+use nostr_url::NostrUrlDecoded;
 
 use crate::git_events::{get_commit_id_from_patch, tag_value};
 pub mod identify_ahead_behind;
@@ -92,6 +93,10 @@ pub trait RepoActions {
     fn get_git_config_item(&self, item: &str, global: Option<bool>) -> Result<Option<String>>;
     fn save_git_config_item(&self, item: &str, value: &str, global: bool) -> Result<()>;
     fn remove_git_config_item(&self, item: &str, global: bool) -> Result<bool>;
+    #[allow(async_fn_in_trait)]
+    async fn get_first_nostr_remote_when_in_ngit_binary(
+        &self,
+    ) -> Result<Option<(String, NostrUrlDecoded)>>;
 }
 
 impl RepoActions for Repo {
@@ -796,6 +801,21 @@ impl RepoActions for Repo {
             Ok(true)
         }
     }
+
+    async fn get_first_nostr_remote_when_in_ngit_binary(
+        &self,
+    ) -> Result<Option<(String, NostrUrlDecoded)>> {
+        for remote_name in self.git_repo.remotes()?.iter().flatten() {
+            if let Some(remote_url) = self.git_repo.find_remote(remote_name)?.url() {
+                if let Ok(nostr_url_decoded) =
+                    NostrUrlDecoded::parse_and_resolve(remote_url, &Some(self)).await
+                {
+                    return Ok(Some((remote_name.to_string(), nostr_url_decoded)));
+                }
+            }
+        }
+        Ok(None)
+    }
 }
 
 fn oid_to_u8_20_bytes(oid: &Oid) -> [u8; 20] {