From 7e1f3a03ea4dea7b6aec39a555ce3caf22b88d8b Mon Sep 17 00:00:00 2001 From: DanConwayDev Date: Tue, 23 Jan 2024 00:00:00 +0000 Subject: fix(prs-create): remove d tag from pr event this shouldn't be present --- src/sub_commands/prs/create.rs | 1 - tests/prs_create.rs | 20 -------------------- 2 files changed, 21 deletions(-) diff --git a/src/sub_commands/prs/create.rs b/src/sub_commands/prs/create.rs index e5d6262..ced1edd 100644 --- a/src/sub_commands/prs/create.rs +++ b/src/sub_commands/prs/create.rs @@ -314,7 +314,6 @@ pub fn generate_pr_and_patch_events( .context("failed to get root commit of the repository")?; let mut pr_tags = vec![ - Tag::Identifier(root_commit.to_string()), Tag::Reference(format!("r-{root_commit}")), Tag::Name(title.to_string()), Tag::Description(description.to_string()), diff --git a/tests/prs_create.rs b/tests/prs_create.rs index d00bb9f..f473683 100644 --- a/tests/prs_create.rs +++ b/tests/prs_create.rs @@ -406,26 +406,6 @@ mod sends_pr_and_2_patches_to_3_relays { mod pr_tags { use super::*; - #[test] - #[serial] - fn pr_tags_repo_commit_as_identifier() -> Result<()> { - let (_, _, r53, r55, r56) = futures::executor::block_on(prep_run_create_pr())?; - let root_commit = GitTestRepo::default().initial_commit()?; - - for relay in [&r53, &r55, &r56] { - let pr_event: &nostr::Event = relay - .events - .iter() - .find(|e| e.kind.as_u64().eq(&PR_KIND)) - .unwrap(); - - // root commit identifier tag - assert!(pr_event.tags.iter().any( - |t| t.as_vec()[0].eq("d") && t.as_vec()[1].eq(&format!("{}", root_commit)) - )); - } - Ok(()) - } #[test] #[serial] -- cgit v1.2.3