From 316f858f223162408cfd52183ef7645828c2f480 Mon Sep 17 00:00:00 2001 From: DanConwayDev Date: Fri, 20 Dec 2024 09:59:14 +0000 Subject: refactor: branch_name handling improve clarity by renaming variables and methods defend against `branch-name` tag with an unsafe name --- src/bin/git_remote_nostr/push.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/bin/git_remote_nostr/push.rs') diff --git a/src/bin/git_remote_nostr/push.rs b/src/bin/git_remote_nostr/push.rs index 05c8fc2..922808c 100644 --- a/src/bin/git_remote_nostr/push.rs +++ b/src/bin/git_remote_nostr/push.rs @@ -1184,7 +1184,8 @@ async fn create_merge_events( term.write_line( format!( "applied commits from proposal: create nostr proposal status event for {}", - event_to_cover_letter(&proposal)?.get_branch_name()?, + event_to_cover_letter(&proposal)? + .get_branch_name_with_pr_prefix_and_shorthand_id()?, ) .as_str(), )?; @@ -1192,7 +1193,8 @@ async fn create_merge_events( term.write_line( format!( "fast-forward merge: create nostr proposal status event for {}", - event_to_cover_letter(&proposal)?.get_branch_name()?, + event_to_cover_letter(&proposal)? + .get_branch_name_with_pr_prefix_and_shorthand_id()?, ) .as_str(), )?; -- cgit v1.2.3