From 56b3c149df70af5d441e8527ec1225e5038bde8e Mon Sep 17 00:00:00 2001 From: DanConwayDev Date: Wed, 18 Feb 2026 22:00:35 +0000 Subject: fix: remove outdated patch_supports gate and fix fetch parent fallback Remove the patch_supports_commit_ids gates in checkout.rs and list.rs that pre-dated the mbox fallback logic. apply_patch_chain already handles all fallback cases. Also replace the main-branch TODO fallback in make_commits_for_proposal with get_parent_commit_from_patch, which uses timestamp-based best-guess when the parent-commit tag is absent. --- src/lib/git_events.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/lib/git_events.rs') diff --git a/src/lib/git_events.rs b/src/lib/git_events.rs index b39e797..32c23ac 100644 --- a/src/lib/git_events.rs +++ b/src/lib/git_events.rs @@ -40,17 +40,16 @@ pub fn get_commit_id_from_patch(event: &Event) -> Result { } } -pub fn get_parent_commit_from_patch( - event: &Event, - git_repo: Option<&Repo>, -) -> Result { +pub fn get_parent_commit_from_patch(event: &Event, git_repo: Option<&Repo>) -> Result { if let Ok(parent) = tag_value(event, "parent-commit") { return Ok(parent); } let metadata = crate::mbox_parser::parse_mbox_patch(&event.content) .context("failed to parse patch for timestamp")?; - let timestamp = metadata.committer_timestamp.unwrap_or(metadata.author_timestamp); + let timestamp = metadata + .committer_timestamp + .unwrap_or(metadata.author_timestamp); if let Some(repo) = git_repo { if let Some(best_guess) = repo -- cgit v1.2.3