From b4459e98d816f6f278a4e9ab76883008d0b946fe Mon Sep 17 00:00:00 2001 From: DanConwayDev Date: Fri, 30 Aug 2024 10:23:28 +0100 Subject: fix(remote): push pr shoudln't connect to server as reported by arjen and tracked via: nostr:nevent1qvzqqqqx25pzpgqgmmc409hm4xsdd74sf68a2uyf9pwel4g9mfdg8l5244t6x4jdqy2hwumn8ghj7ur4wfcxcetjv4kxz7fwvdhk6qpqur335cpnlktwkhv43d8sdk24dpu79jnfuk9qyvk7kga6aencm77sj7e8fa as our tests are connecting to clone url in the file system its difficult to write a test for this --- src/git_remote_helper.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/git_remote_helper.rs b/src/git_remote_helper.rs index c624857..e2de494 100644 --- a/src/git_remote_helper.rs +++ b/src/git_remote_helper.rs @@ -1063,7 +1063,9 @@ fn create_rejected_refspecs_and_remotes_refspecs( refspecs_for_remote.push(refspec.clone()); } } - refspecs_for_remotes.insert(url.to_string(), refspecs_for_remote); + if !refspecs_for_remote.is_empty() { + refspecs_for_remotes.insert(url.to_string(), refspecs_for_remote); + } } // remove rejected refspecs so they dont get pushed to some remotes -- cgit v1.2.3