From a0593e3aa9b19b9ca3c3881cbe0d9d207fe46d2c Mon Sep 17 00:00:00 2001 From: DanConwayDev Date: Tue, 26 Nov 2024 07:48:30 +0000 Subject: refactor: err msgs 'cannot' > 'failed to' in nearly all cases 'cannot' was used when an action was tried and failed. 'failed to' is strictly better because: * just because the action didn't work that time doesnt mean it cannot work * it is better at drawing the users attention to a problem --- tests/ngit_pull.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'tests/ngit_pull.rs') diff --git a/tests/ngit_pull.rs b/tests/ngit_pull.rs index 6637859..2fb9229 100644 --- a/tests/ngit_pull.rs +++ b/tests/ngit_pull.rs @@ -96,7 +96,9 @@ mod when_branch_doesnt_exist { let mut p = CliTester::new_from_dir(&test_repo.dir, ["pull"]); p.expect("fetching updates...\r\n")?; p.expect_eventually("\r\n")?; // some updates listed here - p.expect("Error: cannot find proposal that matches the current branch name\r\n")?; + p.expect( + "Error: failed to find proposal that matches the current branch name\r\n", + )?; p.expect_end()?; -- cgit v1.2.3