From 58cc0a9662e1bd087c2910eb15aa7568f088bba5 Mon Sep 17 00:00:00 2001 From: DanConwayDev Date: Tue, 2 Jul 2024 08:54:55 +0100 Subject: feat(send): tag each maintainer's repo event instead of just tagging the first maintainer's repo event and each maintainer with a p tag This allows for easier discoverability of the proposal when: * the first maintainer hasn't issued a repo event * the maintainers change over time and the single tagged repo event is no listed as a maintainer in anyone elses repo event --- tests/send.rs | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/send.rs b/tests/send.rs index 2c95e1e..0169c82 100644 --- a/tests/send.rs +++ b/tests/send.rs @@ -375,7 +375,7 @@ mod when_cover_letter_details_specified_with_range_of_head_2_sends_cover_letter_ #[tokio::test] #[serial] - async fn a_tag_for_repo_event() -> Result<()> { + async fn a_tag_for_repo_event_of_each_maintainer() -> Result<()> { let (_, _, r53, r55, r56) = prep_run_create_proposal(true).await?; for relay in [&r53, &r55, &r56] { let cover_letter_event: &nostr::Event = @@ -385,6 +385,11 @@ mod when_cover_letter_details_specified_with_range_of_head_2_sends_cover_letter_ "{REPOSITORY_KIND}:{TEST_KEY_1_PUBKEY_HEX}:{}", generate_repo_ref_event().identifier().unwrap() )))); + assert!(cover_letter_event.iter_tags().any(|t| t.as_vec()[0].eq("a") + && t.as_vec()[1].eq(&format!( + "{REPOSITORY_KIND}:{TEST_KEY_2_PUBKEY_HEX}:{}", + generate_repo_ref_event().identifier().unwrap() + )))); } Ok(()) } @@ -564,7 +569,7 @@ mod when_cover_letter_details_specified_with_range_of_head_2_sends_cover_letter_ #[tokio::test] #[serial] - async fn a_tag_for_repo_event() -> Result<()> { + async fn a_tag_for_repo_event_of_each_maintainer() -> Result<()> { assert!(prep().await?.tags.iter().any(|t| { t.as_vec()[0].eq("a") && t.as_vec()[1].eq(&format!( @@ -572,6 +577,13 @@ mod when_cover_letter_details_specified_with_range_of_head_2_sends_cover_letter_ generate_repo_ref_event().identifier().unwrap() )) })); + assert!(prep().await?.tags.iter().any(|t| { + t.as_vec()[0].eq("a") + && t.as_vec()[1].eq(&format!( + "{REPOSITORY_KIND}:{TEST_KEY_2_PUBKEY_HEX}:{}", + generate_repo_ref_event().identifier().unwrap() + )) + })); Ok(()) } -- cgit v1.2.3