1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
|
use anyhow::{Context, Result};
use nostr::prelude::*;
use zeroize::Zeroize;
use super::encryption::{EncryptDecrypt, Encryptor};
use crate::{
cli_interactor::{Interactor, InteractorPrompt, PromptInputParms, PromptPasswordParms},
config::{self, ConfigManagement, ConfigManager},
};
#[derive(Default)]
pub struct UserManager {
config_manager: ConfigManager,
interactor: Interactor,
encryptor: Encryptor,
}
pub trait UserManagement {
fn add(&self, nsec: &Option<String>, password: &Option<String>) -> Result<nostr::Keys>;
}
#[cfg(test)]
use duplicate::duplicate_item;
#[cfg_attr(test, duplicate_item(UserManager; [UserManager]; [self::tests::MockUserManager]))]
impl UserManagement for UserManager {
fn add(&self, nsec: &Option<String>, password: &Option<String>) -> Result<nostr::Keys> {
let mut prompt = "login with nsec (or hex private key)";
let keys = loop {
let pk = match nsec.clone() {
Some(nsec) => nsec,
None => self
.interactor
.input(PromptInputParms::default().with_prompt(prompt))
.context("failed to get nsec input from interactor")?,
};
match Keys::from_sk_str(&pk) {
Ok(key) => {
break key;
}
Err(e) => {
if nsec.is_some() {
return Err(e).context(
"invalid nsec - supplied parameter could not be converted into a nostr private key",
);
}
prompt = "invalid nsec. try again with nsec (or hex private key)";
}
}
};
let mut pass = match password.clone() {
Some(pass) => pass,
None => self
.interactor
.password(
PromptPasswordParms::default()
.with_prompt("encrypt with password")
.with_confirm(),
)
.context("failed to get password input from interactor.password")?,
};
let encrypted_secret_key = self
.encryptor
.encrypt_key(&keys, &pass)
.context("failed to encrypt nsec with password.")?;
pass.zeroize();
let user_ref = config::UserRef {
public_key: keys.public_key(),
encrypted_key: encrypted_secret_key,
};
// remove any duplicate entries for key before adding it to config
let mut cfg = self.config_manager.load().context("failed to load application config to find and remove any old versions of the user's encrypted key")?;
cfg.users = cfg
.users
.clone()
.into_iter()
.filter(|r| !r.public_key.eq(&keys.public_key()))
.collect();
cfg.users.push(user_ref);
self.config_manager
.save(&cfg)
.context("failed to save application configuration with new user details in")?;
Ok(keys)
}
}
#[cfg(test)]
mod tests {
use test_utils::*;
use super::*;
use crate::{
cli_interactor::MockInteractorPrompt,
config::{MockConfigManagement, MyConfig, UserRef},
key_handling::encryption::MockEncryptDecrypt,
};
#[derive(Default)]
pub struct MockUserManager {
pub config_manager: MockConfigManagement,
pub interactor: MockInteractorPrompt,
pub encryptor: MockEncryptDecrypt,
}
mod add {
use super::*;
impl MockUserManager {
fn add_return_expected_responses(mut self) -> Self {
self.config_manager
.expect_load()
.returning(|| Ok(MyConfig::default()));
self.config_manager.expect_save().returning(|_| Ok(()));
self.interactor
.expect_input()
.returning(|_| Ok(TEST_KEY_1_NSEC.into()));
self.interactor
.expect_password()
.returning(|_| Ok(TEST_PASSWORD.into()));
self.encryptor
.expect_encrypt_key()
.returning(|_, _| Ok(TEST_KEY_1_ENCRYPTED.into()));
self
}
}
fn reuable_user_isnt_prompted(nsec: &str) {
let mut m = MockUserManager::default().add_return_expected_responses();
m.interactor = MockInteractorPrompt::default();
m.interactor.expect_input().never();
m.interactor.expect_password().never();
let _ = m.add(&Some(nsec.into()), &Some(TEST_PASSWORD.to_string()));
}
fn reuable_config_isnt_modified(nsec: &str) {
let mut m = MockUserManager::default();
m.config_manager.expect_save().never();
let _ = m.add(&Some(nsec.into()), &Some(TEST_PASSWORD.to_string()));
}
mod when_valid_nsec_and_password_is_passed {
use super::*;
#[test]
fn user_isnt_prompted() {
reuable_user_isnt_prompted(TEST_KEY_1_NSEC);
}
#[test]
fn results_in_correct_keys() {
let mut m = MockUserManager::default().add_return_expected_responses();
m.interactor = MockInteractorPrompt::default();
m.interactor.expect_input().never();
m.interactor.expect_password().never();
let r = m.add(
&Some(TEST_KEY_1_NSEC.into()),
&Some(TEST_PASSWORD.to_string()),
);
assert!(r.is_ok(), "should result in keys");
assert!(
r.is_ok_and(|k| k
.secret_key()
.is_ok_and(|k| k.display_secret().to_string().eq(TEST_KEY_1_SK_HEX))),
"keys should reflect nsec"
);
}
}
mod when_invalid_nsec_is_passed_with_password {
use super::*;
#[test]
fn user_isnt_prompted() {
reuable_user_isnt_prompted(TEST_INVALID_NSEC);
}
#[test]
fn config_isnt_modified() {
reuable_config_isnt_modified(TEST_INVALID_NSEC);
}
#[test]
fn results_in_an_error() {
let m = MockUserManager::default();
assert!(
m.add(
&Some(TEST_INVALID_NSEC.into()),
&Some(TEST_PASSWORD.to_string())
)
.is_err(),
"should result in an error"
);
}
}
mod when_no_nsec_is_passed {
use super::*;
#[test]
fn prompt_for_nsec_and_password() {
let mut m = MockUserManager::default().add_return_expected_responses();
m.interactor = MockInteractorPrompt::new();
m.interactor
.expect_input()
.once()
.withf(|p| p.prompt.eq("login with nsec (or hex private key)"))
.returning(|_| Ok(TEST_KEY_1_NSEC.into()));
m.interactor
.expect_password()
.once()
.withf(|p| p.prompt.eq("encrypt with password"))
.returning(|_| Ok(TEST_KEY_1_NSEC.into()));
let _ = m.add(&None, &None);
}
#[test]
fn results_in_correct_keys() {
let m = MockUserManager::default().add_return_expected_responses();
let r = m.add(&None, &None);
assert!(r.is_ok(), "should result in keys");
assert!(
r.is_ok_and(|k| k
.secret_key()
.is_ok_and(|k| k.display_secret().to_string().eq(TEST_KEY_1_SK_HEX))),
"keys should reflect nsec"
);
}
#[test]
fn stores_encrypted_key_in_config() {
let mut m = MockUserManager::default().add_return_expected_responses();
m.config_manager = MockConfigManagement::new();
m.config_manager
.expect_load()
.returning(|| Ok(MyConfig::default()));
m.config_manager
.expect_save()
.withf(|cfg| {
cfg.users.len().eq(&1)
&& cfg.users[0].encrypted_key.eq(TEST_KEY_1_ENCRYPTED)
})
.returning(|_| Ok(()));
let _ = m.add(&None, &None);
}
#[test]
fn stored_key_encrypted_with_password() {
let mut m = MockUserManager::default().add_return_expected_responses();
m.encryptor = MockEncryptDecrypt::new();
m.encryptor
.expect_encrypt_key()
.once()
.withf(|k, p| {
k.eq(&Keys::from_sk_str(TEST_KEY_1_NSEC).unwrap()) && p.eq(TEST_PASSWORD)
})
.returning(|_, _| Ok(TEST_KEY_1_ENCRYPTED.into()));
let _ = m.add(&None, &None);
}
mod when_user_key_already_stored {
use super::*;
use crate::config::UserRef;
/// key overwritten as password may have changed
#[test]
fn key_not_saved_as_duplicate_but_encrypted_key_overwritten() {
let mut m = MockUserManager::default().add_return_expected_responses();
m.config_manager = MockConfigManagement::default();
m.config_manager.expect_load().returning(|| {
Ok(MyConfig {
users: vec![UserRef {
public_key: TEST_KEY_1_KEYS.public_key(),
// different key to TEST_KEY_1_ENCYPTED
encrypted_key: TEST_KEY_2_ENCRYPTED.into(),
}],
..MyConfig::default()
})
});
m.config_manager
.expect_save()
.withf(|cfg| {
cfg.users.len() == 1
&& cfg.users[0].encrypted_key.eq(TEST_KEY_1_ENCRYPTED)
})
.returning(|_| Ok(()));
let _ = m.add(&None, &None);
}
}
mod when_multiple_users_added {
use super::*;
#[test]
fn both_user_keys_are_stored() {
let mut m = MockUserManager::default().add_return_expected_responses();
m.config_manager = MockConfigManagement::default();
m.config_manager.expect_load().returning(|| {
Ok(MyConfig {
users: vec![UserRef {
public_key: TEST_KEY_2_KEYS.public_key(),
encrypted_key: TEST_KEY_2_ENCRYPTED.into(),
}],
..MyConfig::default()
})
});
m.config_manager
.expect_save()
.withf(|cfg| {
cfg.users.len() == 2
// latest user stored at end of array
&& cfg.users[1].encrypted_key.eq(TEST_KEY_1_ENCRYPTED)
})
.returning(|_| Ok(()));
let _ = m.add(&None, &None);
}
}
}
}
}
|