npub1tkq8unhsd5jqx6ueex5lcpsgknrpquxuk44ftpjlpm3ulaake7xs76txrw/ngit-grasp-mirror/src/git/mod.rs, branch masterUnnamed repository; edit this file 'description' to name the repository.
https://upleb.uk/npub1tkq8unhsd5jqx6ueex5lcpsgknrpquxuk44ftpjlpm3ulaake7xs76txrw/ngit-grasp-mirror/atom?h=master2026-04-10T16:42:35+00:00fix: accept any d-tag identifier; percent-encode in URLs2026-04-10T16:42:35+00:00DanConwayDevDanConwayDev@protonmail.com2026-04-10T16:42:35+00:00urn:sha1:dfd20a39a7ddaea07103cac45d4d79bc7e6ce0d7
NIP-01 places no restriction on d tag characters and NIP-34 only
recommends kebab-case without mandating it. Rejecting identifiers with
whitespace or other URL-unsafe characters was therefore overly strict.
The correct approach (per NIP-34 PR #2312 and GRASP-01) is to store
identifiers verbatim on disk and percent-encode them when constructing
URLs. The previous commit already handled the incoming direction
(percent-decoding URL paths before filesystem lookup); this commit
handles the outgoing direction and removes the validation restriction.
Changes:
- validate_identifier: drop whitespace rejection; only reject chars
that are unsafe as filesystem directory names (/, \, null, . / ..)
- git/mod.rs: add percent_encode() alongside percent_decode()
- landing.rs: percent-encode identifier in nostr:// clone URL and
gitworkshop link (also fixes a pre-existing bug where the clone URL
displayed literal '{npub}' / '{identifier}' instead of the values)
fix: reject identifiers with whitespace and URL-decode path components2026-04-09T15:24:17+00:00DanConwayDevDanConwayDev@protonmail.com2026-04-09T15:24:17+00:00urn:sha1:2d74b9ca69b3a1e0b9a2359c12cc2d1979fc6130
Two bugs allowed a repository announcement with a space-containing
identifier ('kuboslopp by Shakespeare') to enter purgatory and create
a bare repo on disk, but then fail to serve git data over HTTP.
Bug 1 (serving): parse_git_url and parse_repo_url did not percent-decode
the URL path before resolving the filesystem path. A client requesting
/npub.../kuboslopp%20by%20Shakespeare.git/info/refs had the identifier
extracted as 'kuboslopp%20by%20Shakespeare' (literal %20), which did not
match the on-disk directory 'kuboslopp by Shakespeare.git'.
Fix: add percent_decode() in src/git/mod.rs and apply it to the repo
component in both parse_git_url and parse_repo_url.
Bug 2 (validation): validate_announcement did not check that the
identifier is safe as a filesystem path component and URL segment.
Identifiers containing whitespace, path separators, null bytes, or
reserved names (. / ..) should be rejected at acceptance time.
Fix: add validate_identifier() in src/nostr/events.rs and call it from
validate_announcement before any other policy checks.
Reduce log noise: change per-ref updates to DEBUG level2026-02-03T21:49:38+00:00DanConwayDevDanConwayDev@protonmail.com2026-02-03T21:49:38+00:00urn:sha1:f200bd1bde04ff79a40c8d73df0edde2cf28493c
Only the final summary 'Aligned repository with state' remains at INFO level,
showing the total count of refs_created/refs_updated/refs_deleted.
test: disable GPG signing in all test helpers2026-01-08T00:49:57+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-08T00:49:57+00:00urn:sha1:3f14f998d64b5fa15bdddd7570b4f72874eb9f29
Prevent GPG signing prompts (including Yubikey activation) during test runs
by explicitly disabling commit.gpgsign and tag.gpgsign in all test repository
creation helpers.
Modified:
- tests/common/purgatory_helpers.rs: create_test_repo_with_commit()
- src/git/mod.rs: create_test_repo_with_commit()
- src/purgatory/helpers.rs: create_test_repo_with_commit()
All test repositories now have GPG signing disabled regardless of global
git configuration.
refactor: unify event processing logic2026-01-07T23:31:38+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-07T23:31:38+00:00urn:sha1:c67ebe6f33bfa191f17eb0df24d3ee18092c74e1
Eliminates code duplication by extracting core event processing into
reusable functions. All state and PR event processing now uses the same
unified logic from src/git/process.rs.
Changes:
- Add src/git/process.rs with unified processing functions
- process_state_with_git_data() for state events
- process_pr_with_git_data() for PR events
- Pure functions with comprehensive result types
- Refactor policy handlers to use unified processing
- src/nostr/policy/state.rs: Remove ~70 lines of duplicated logic
- src/nostr/policy/pr_event.rs: Remove ~40 lines of duplicated logic
- Refactor purgatory processing to use unified functions
- src/git/sync.rs: Remove ~125 lines of duplicated logic
- Make extract_owner_from_repo_path() public for reuse
Benefits:
- DRY: Single source of truth for event processing
- Testable: Pure functions with clear contracts
- Maintainable: Changes happen in one place
- Consistent: All code paths use same logic
All 217 unit tests + 40 integration tests pass (257/257).
sync all repos when authorised state data push received2026-01-05T14:54:29+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-05T14:54:29+00:00urn:sha1:3f50107062d55a15decc47e93fd4e9f473de86e8purgatory: fix pr event recieve code2025-12-31T10:49:09+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-31T09:18:21+00:00urn:sha1:768fe91caa676e4501aa26e14e01ca47f3ea4ca1purgatory: fix state event receive code2025-12-31T09:17:49+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-31T09:17:49+00:00urn:sha1:3d6901831904141166d9ed8f47813c45cba109b6feat(purgatory): add broken purgatory implementation2025-12-24T11:54:18+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-24T08:02:12+00:00urn:sha1:70d0197e85ae4ef85202781f6d2dc9e76bd508b3try and add / update / delete refs on state update2025-12-01T17:04:43+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-01T17:04:43+00:00urn:sha1:d0592943867b7003b30a778acff8fcc43c041e34
if we have the OIDs