npub1tkq8unhsd5jqx6ueex5lcpsgknrpquxuk44ftpjlpm3ulaake7xs76txrw/ngit-grasp-mirror/tests/common/sync_helpers.rs, branch masterUnnamed repository; edit this file 'description' to name the repository.
https://upleb.uk/npub1tkq8unhsd5jqx6ueex5lcpsgknrpquxuk44ftpjlpm3ulaake7xs76txrw/ngit-grasp-mirror/atom?h=master2026-02-26T15:42:09+00:00chore: apply cargo fmt and fix clippy warnings2026-02-26T15:42:09+00:00DanConwayDevDanConwayDev@protonmail.com2026-02-26T15:42:09+00:00urn:sha1:9d86cf15f0275ffeee4519bd054e3b61dc8992ac
Fix pre-existing clippy lints:
- &PathBuf -> &Path in audit_cleanup.rs
- too_many_arguments on process_newly_available_git_data,
process_purgatory_announcements, and HttpService::new
- clone_on_copy for PublicKey (Copy type) in purgatory cleanup loop
test: update sync tests to set up git data for purgatory flow2026-02-23T12:05:05+00:00DanConwayDevDanConwayDev@protonmail.com2026-02-18T23:17:08+00:00urn:sha1:49b9405dfcbb872686acdd7abc12dc9c94adc2ab
All sync tests now create a local git repo, send announcement + state
event to the source relay, and push git data to release both from
purgatory before the syncing relay starts bootstrap sync.
test: update run_sync_test to use push_to_relay for purgatory flow2026-02-18T22:56:13+00:00DanConwayDevDanConwayDev@protonmail.com2026-02-18T22:56:13+00:00urn:sha1:63865548b07e44d69321af3b03ca2c29aa60d74d
Previously run_sync_test used a SmartGitServer external to the relay,
but never pushed to the source relay itself. With the announcement
purgatory feature, announcements stay in purgatory until git data
arrives. By using push_to_relay to the source relay, both the
announcement and state event are released from purgatory before
the syncing relay starts, allowing the announcement to be synced.
chore: cargo fmt2026-01-09T19:58:41+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-09T19:58:41+00:00urn:sha1:b28a356cb41077ccee12a9c52f4ef2054e76cac6Fix sync tests after Syncing status introduction2026-01-09T15:32:02+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-09T15:32:02+00:00urn:sha1:29be4cb7d0fbd29325c995a76ba1b1f47beecca5
- Fix relay_connected() helper to check v >= 2 (Syncing/Connected states)
- Fix unit test to use status value 3 (Connected) instead of 1 (Connecting)
- Fix clippy warning: use .to_vec() instead of .iter().cloned().collect()
All 61 sync integration tests now passing.
All 238 unit tests passing.
Clippy clean.
refactor: replace hardcoded Kind constants with rust-nostr variants2026-01-08T11:23:28+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-08T11:20:35+00:00urn:sha1:5d02ad6b893f9059044914c115d77cf9d8e589c3
- Replace KIND_REPOSITORY_ANNOUNCEMENT with Kind::GitRepoAnnouncement
- Replace KIND_REPOSITORY_STATE with Kind::RepoState
- Replace KIND_PR with Kind::GitPullRequest
- Replace KIND_PR_UPDATE with Kind::GitPullRequestUpdate
- Replace KIND_USER_GRASP_LIST with Kind::GitUserGraspList
- Replace KIND_PATCH with Kind::GitPatch
- Replace KIND_ISSUE with Kind::GitIssue
- Replace KIND_COMMENT with Kind::Comment
- Replace all Kind::Custom(30617|30618|1617|1618|1619|1621|1111|10317) patterns
- Remove all hardcoded KIND_* constants from events.rs
- Update all match statements to use Kind enum directly
- Update all filter builders to use Kind variants
- Update all test helpers and assertions
Benefits:
- Type safety: compiler prevents wrong kind numbers
- Readability: Kind::GitRepoAnnouncement is self-documenting
- Maintainability: single source of truth (rust-nostr)
- IDE support: full autocompletion and refactoring
- Standards: aligns with rust-nostr best practices
Files modified: 21
Constants removed: 9
Patterns replaced: 100+
Tests passing: 222/222
fix: include npub in clone URLs generated by create_repo_announcement2026-01-07T15:39:41+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-07T15:39:41+00:00urn:sha1:7dcbc84806e7b3000835eb9132dfc4e9003e382a
The clone URL format should be http://{domain}/{npub}/{identifier}.git
but was missing the npub segment. This caused git push authorization
to fail because the URL didn't match the expected repository path.
test: fix issue kind number2026-01-02T12:14:50+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-02T12:14:50+00:00urn:sha1:6e70994a30a0d0e537099094df2a8369b559586dchore: cargo fmt and clippy2025-12-22T21:03:49+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-22T21:03:49+00:00urn:sha1:6b55efedba7c069eff7a3e335845a961d40274dbSimplify sync metrics to track only newly saved events2025-12-19T15:59:23+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-19T15:53:48+00:00urn:sha1:02a90c109d4d08c6a54184f821c100f4eba92545
Replace broken event counting that occurred before duplicate/policy checks
with accurate tracking of events that are new, accepted, and saved.
Changes:
- Added ProcessResult enum to track event processing outcomes
- Modified process_event_static() to return ProcessResult
- Replaced events_total (with source labels) with events_synced_total
- Removed gap_events_total and event_source module
- Removed eose_received flag (EOSE is per-subscription, not suitable)
- Updated all tests to use new simplified API
The new ngit_sync_events_synced_total metric only counts events that:
1. Are new (not duplicates)
2. Pass write policy validation
3. Are successfully saved to database
All 165 tests pass (124 lib + 41 integration)