npub1tkq8unhsd5jqx6ueex5lcpsgknrpquxuk44ftpjlpm3ulaake7xs76txrw/ngit-grasp-mirror/tests/sync/discovery.rs, branch masterUnnamed repository; edit this file 'description' to name the repository.
https://upleb.uk/npub1tkq8unhsd5jqx6ueex5lcpsgknrpquxuk44ftpjlpm3ulaake7xs76txrw/ngit-grasp-mirror/atom?h=master2026-02-26T15:42:09+00:00chore: apply cargo fmt and fix clippy warnings2026-02-26T15:42:09+00:00DanConwayDevDanConwayDev@protonmail.com2026-02-26T15:42:09+00:00urn:sha1:9d86cf15f0275ffeee4519bd054e3b61dc8992ac
Fix pre-existing clippy lints:
- &PathBuf -> &Path in audit_cleanup.rs
- too_many_arguments on process_newly_available_git_data,
process_purgatory_announcements, and HttpService::new
- clone_on_copy for PublicKey (Copy type) in purgatory cleanup loop
remove recursive relay discovery test2026-02-23T12:05:07+00:00DanConwayDevDanConwayDev@protonmail.com2026-02-23T09:22:41+00:00urn:sha1:9f15929b10825c2f55434a98794fc551794cad2b
Recursive discovery relied on announcement events being gossiped across
relays regardless of whether they listed the service. Now that
announcements enter purgatory until state event and git data arrive,
cross-relay discovery cannot be triggered by a synced announcement alone,
making the three-relay recursive discovery scenario impossible.
test: update sync tests to set up git data for purgatory flow2026-02-23T12:05:05+00:00DanConwayDevDanConwayDev@protonmail.com2026-02-18T23:17:08+00:00urn:sha1:49b9405dfcbb872686acdd7abc12dc9c94adc2ab
All sync tests now create a local git repo, send announcement + state
event to the source relay, and push git data to release both from
purgatory before the syncing relay starts bootstrap sync.
refactor: replace hardcoded Kind constants with rust-nostr variants2026-01-08T11:23:28+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-08T11:20:35+00:00urn:sha1:5d02ad6b893f9059044914c115d77cf9d8e589c3
- Replace KIND_REPOSITORY_ANNOUNCEMENT with Kind::GitRepoAnnouncement
- Replace KIND_REPOSITORY_STATE with Kind::RepoState
- Replace KIND_PR with Kind::GitPullRequest
- Replace KIND_PR_UPDATE with Kind::GitPullRequestUpdate
- Replace KIND_USER_GRASP_LIST with Kind::GitUserGraspList
- Replace KIND_PATCH with Kind::GitPatch
- Replace KIND_ISSUE with Kind::GitIssue
- Replace KIND_COMMENT with Kind::Comment
- Replace all Kind::Custom(30617|30618|1617|1618|1619|1621|1111|10317) patterns
- Remove all hardcoded KIND_* constants from events.rs
- Update all match statements to use Kind enum directly
- Update all filter builders to use Kind variants
- Update all test helpers and assertions
Benefits:
- Type safety: compiler prevents wrong kind numbers
- Readability: Kind::GitRepoAnnouncement is self-documenting
- Maintainability: single source of truth (rust-nostr)
- IDE support: full autocompletion and refactoring
- Standards: aligns with rust-nostr best practices
Files modified: 21
Constants removed: 9
Patterns replaced: 100+
Tests passing: 222/222
test: clear names for sync tests2025-12-19T09:25:34+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-19T09:25:34+00:00urn:sha1:15452be55e727552df10e11facfaf67700845e3afix: resolve all fmt and clippy warnings2025-12-11T16:53:03+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-11T16:53:03+00:00urn:sha1:2a9160836bb87fdea3ae891563b0169c68d1c2ab
Main lib (src/):
- Add #[allow(dead_code)] for build_info field (stored to prevent Prometheus unregistration)
- Add #[allow(dead_code)] for first_seen field (reserved for future rate limiting)
- Replace .or_insert_with(RelaySyncNeeds::default) with .or_default()
- Replace manual div_ceil implementations with .div_ceil(100)
Test code (tests/):
- Replace .expect(&format!(...)) with .unwrap_or_else(|_| panic!(...))
- Remove needless borrows in fetch_metrics() calls
- Add #[allow(dead_code)] and #[allow(unused_imports)] to test helpers module
grasp-audit:
- Apply cargo fmt to fix formatting
feat(sync): broadcast synced events to WebSocket subscribers2025-12-10T21:24:21+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-10T21:24:21+00:00urn:sha1:466a009d8248aab274a9da419e4c0d83a4b9f466
Enable recursive relay discovery by broadcasting synced events to
WebSocket subscribers via LocalRelay.notify_event(). This allows the
SelfSubscriber to receive 30617 announcements synced from external
relays and discover additional relay URLs to connect to.
Changes:
- Pass LocalRelay to SyncManager::new() from main.rs
- Add local_relay field to SyncManager struct
- Call notify_event() after saving synced events to database
- Enable test_recursive_relay_discovery_syncs_announcement test
The test verifies that when relay_a syncs announcement_x from bootstrap
relay_b (which lists relay_c), relay_a discovers and connects to
relay_c to sync announcement_y.
Fixes recursive relay discovery from bootstrap sync.
test(sync): add 3-relay recursive discovery test2025-12-10T17:08:01+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-10T17:08:01+00:00urn:sha1:d3d0b28b0ba07f5572151e82339ab8871ff34e52refactor(tests): extract shared create_repo_announcement helper2025-12-10T16:59:09+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-10T16:59:09+00:00urn:sha1:cbed48d5a20b646a5bcc23e907d6163a3a8d36c5Phase 5: Migrate bootstrap and discovery tests2025-12-10T16:13:51+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-10T16:13:51+00:00urn:sha1:d08878d0b9a8738e57e457a916677d2061775cbd
Create organized test structure for proactive sync:
tests/common/sync_helpers.rs (from Phase 4):
- TestClient with retry logic for connect/send
- Event builders: build_layer2_issue_event, build_layer3_comment_event
- Tag variants (a/A/q for Layer 2, e/E/q for Layer 3)
- wait_for_event_on_relay() assertion helper
- repo_coord() utility function
- Unit tests for all builders
tests/sync/mod.rs:
- Module organization for sync tests
- Documentation of test categories
tests/sync.rs:
- Main test harness including common and sync modules
tests/sync/bootstrap.rs:
- test_bootstrap_syncs_existing_layer2_events (Test 1)
- test_relay_replays_events_after_restart (Test 4)
tests/sync/discovery.rs:
- test_discovers_layer3_via_layer2 (Test 2)
- test_layer2_discovery_with_chain (Test 3 - simplified)
All 14 tests pass: cargo test --test sync