npub1tkq8unhsd5jqx6ueex5lcpsgknrpquxuk44ftpjlpm3ulaake7xs76txrw/ngit-grasp-mirror/tests/sync/metrics.rs, branch v1.0.0Unnamed repository; edit this file 'description' to name the repository.
https://upleb.uk/npub1tkq8unhsd5jqx6ueex5lcpsgknrpquxuk44ftpjlpm3ulaake7xs76txrw/ngit-grasp-mirror/atom?h=v1.0.02026-02-23T12:05:05+00:00test: update sync tests to set up git data for purgatory flow2026-02-23T12:05:05+00:00DanConwayDevDanConwayDev@protonmail.com2026-02-18T23:17:08+00:00urn:sha1:49b9405dfcbb872686acdd7abc12dc9c94adc2ab
All sync tests now create a local git repo, send announcement + state
event to the source relay, and push git data to release both from
purgatory before the syncing relay starts bootstrap sync.
refactor: replace hardcoded Kind constants with rust-nostr variants2026-01-08T11:23:28+00:00DanConwayDevDanConwayDev@protonmail.com2026-01-08T11:20:35+00:00urn:sha1:5d02ad6b893f9059044914c115d77cf9d8e589c3
- Replace KIND_REPOSITORY_ANNOUNCEMENT with Kind::GitRepoAnnouncement
- Replace KIND_REPOSITORY_STATE with Kind::RepoState
- Replace KIND_PR with Kind::GitPullRequest
- Replace KIND_PR_UPDATE with Kind::GitPullRequestUpdate
- Replace KIND_USER_GRASP_LIST with Kind::GitUserGraspList
- Replace KIND_PATCH with Kind::GitPatch
- Replace KIND_ISSUE with Kind::GitIssue
- Replace KIND_COMMENT with Kind::Comment
- Replace all Kind::Custom(30617|30618|1617|1618|1619|1621|1111|10317) patterns
- Remove all hardcoded KIND_* constants from events.rs
- Update all match statements to use Kind enum directly
- Update all filter builders to use Kind variants
- Update all test helpers and assertions
Benefits:
- Type safety: compiler prevents wrong kind numbers
- Readability: Kind::GitRepoAnnouncement is self-documenting
- Maintainability: single source of truth (rust-nostr)
- IDE support: full autocompletion and refactoring
- Standards: aligns with rust-nostr best practices
Files modified: 21
Constants removed: 9
Patterns replaced: 100+
Tests passing: 222/222
Simplify sync metrics to track only newly saved events2025-12-19T15:59:23+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-19T15:53:48+00:00urn:sha1:02a90c109d4d08c6a54184f821c100f4eba92545
Replace broken event counting that occurred before duplicate/policy checks
with accurate tracking of events that are new, accepted, and saved.
Changes:
- Added ProcessResult enum to track event processing outcomes
- Modified process_event_static() to return ProcessResult
- Replaced events_total (with source labels) with events_synced_total
- Removed gap_events_total and event_source module
- Removed eose_received flag (EOSE is per-subscription, not suitable)
- Updated all tests to use new simplified API
The new ngit_sync_events_synced_total metric only counts events that:
1. Are new (not duplicates)
2. Pass write policy validation
3. Are successfully saved to database
All 165 tests pass (124 lib + 41 integration)
test: fix test_multi_source_aggregate_counts2025-12-19T09:36:17+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-19T09:36:17+00:00urn:sha1:73a89750c842af98ca0e064dd1c1cac1875214d1test: fix test_live_sync_event_count2025-12-19T09:25:50+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-19T09:25:50+00:00urn:sha1:39e4fa068364ff0be14c6d1fcf89591feba2a14fsync: turn off negentropy and fix some tests2025-12-18T16:46:53+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-18T16:46:53+00:00urn:sha1:6ad7136027c56c3a523278d90ade3da018e39273sync: fix sync connection2025-12-18T12:41:19+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-18T12:41:19+00:00urn:sha1:11a656fa96d6f60e2d8e8fd31657e24d6cc7cf21fix: resolve all fmt and clippy warnings2025-12-11T16:53:03+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-11T16:53:03+00:00urn:sha1:2a9160836bb87fdea3ae891563b0169c68d1c2ab
Main lib (src/):
- Add #[allow(dead_code)] for build_info field (stored to prevent Prometheus unregistration)
- Add #[allow(dead_code)] for first_seen field (reserved for future rate limiting)
- Replace .or_insert_with(RelaySyncNeeds::default) with .or_default()
- Replace manual div_ceil implementations with .div_ceil(100)
Test code (tests/):
- Replace .expect(&format!(...)) with .unwrap_or_else(|_| panic!(...))
- Remove needless borrows in fetch_metrics() calls
- Add #[allow(dead_code)] and #[allow(unused_imports)] to test helpers module
grasp-audit:
- Apply cargo fmt to fix formatting
fix: sync metrics aggregate relay counts2025-12-11T13:19:08+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-11T13:19:08+00:00urn:sha1:9d1545b7b13bc6cd3b0a075865918ceaad9e07fffix: classify sync events as startup/live based on EOSE, not relay type2025-12-11T13:09:39+00:00DanConwayDevDanConwayDev@protonmail.com2025-12-11T13:09:39+00:00urn:sha1:7146ee550944c71a4e48018a34820ce9a9d99f95
Previously, events were classified as 'startup' or 'live' based on whether
they came from a bootstrap relay (is_bootstrap flag). This meant ALL events
from bootstrap relays were counted as 'startup', even events received after
the initial sync completed.
Now events are classified based on whether EOSE (End Of Stored Events) has
been received for that connection:
- Events BEFORE EOSE → 'startup' (historical events during initial sync)
- Events AFTER EOSE → 'live' (new events via real-time subscription)
This enables the test_live_sync_event_count test which validates that events
received after sync connection is established are counted as live events.
Also removed the #[ignore] attribute from test_live_sync_event_count since
the metrics are now properly wired up.