From 22d93ea5e707e99d67ab367d60c7a9d867b7665c Mon Sep 17 00:00:00 2001 From: DanConwayDev Date: Tue, 3 Feb 2026 22:00:31 +0000 Subject: Add error logging to all git handler IO operations Previously, some IO errors in git handlers were logged while others were not, leading to inconsistent observability. Additionally, the HTTP layer logged all git errors redundantly, adding no useful context beyond what was already logged at the source. Changes: - Add error logging to all previously unlogged IO operations in handle_upload_pack and handle_receive_pack (stdin writes, stdout/stderr reads, process waits) - Remove redundant error logging at HTTP layer since all errors are now logged at their source with full context - Ensures consistent error-level logging for all git subprocess failures This provides complete observability of git operations while eliminating duplicate log entries that don't add value. --- src/http/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/http') diff --git a/src/http/mod.rs b/src/http/mod.rs index ffb1562..edc28a3 100644 --- a/src/http/mod.rs +++ b/src/http/mod.rs @@ -332,7 +332,7 @@ impl Service> for HttpService { .unwrap()) } Err(e) => { - tracing::error!("Git handler error: {}", e); + // Errors are already logged at their source with full context let error_msg = format!("Git error: {}", e); Ok(add_cors_headers(Response::builder()) .status(e.status_code()) -- cgit v1.2.3