From 0f1ea0290d1b5418ec1d22bfa7c837e767a35d6c Mon Sep 17 00:00:00 2001 From: DanConwayDev Date: Thu, 11 Dec 2025 13:29:30 +0000 Subject: chore: remove unused sync config fields Remove 4 config fields that were defined but never used: - sync_startup_delay_secs - sync_reconnect_delay_secs - sync_reconnect_lookback_days - sync_startup_jitter_ms These fields were added during GRASP-02 planning but the implementation took a different approach (using hardcoded constants for quick reconnect windows and batch window via env var). --- src/config.rs | 21 --------------------- src/http/nip11.rs | 8 -------- 2 files changed, 29 deletions(-) (limited to 'src') diff --git a/src/config.rs b/src/config.rs index 178e840..f3a3e2a 100644 --- a/src/config.rs +++ b/src/config.rs @@ -93,23 +93,6 @@ pub struct Config { #[arg(long, env = "NGIT_SYNC_MAX_BACKOFF_SECS", default_value_t = 3600)] pub sync_max_backoff_secs: u64, - /// Delay in seconds before running startup catchup (default: 30) - #[arg(long, env = "NGIT_SYNC_STARTUP_DELAY_SECS", default_value_t = 30)] - pub sync_startup_delay_secs: u64, - - /// Delay in seconds before running reconnect catchup (default: 10) - #[arg(long, env = "NGIT_SYNC_RECONNECT_DELAY_SECS", default_value_t = 10)] - pub sync_reconnect_delay_secs: u64, - - /// Number of days to look back for reconnect catchup (default: 3) - #[arg(long, env = "NGIT_SYNC_RECONNECT_LOOKBACK_DAYS", default_value_t = 3)] - pub sync_reconnect_lookback_days: u64, - - /// Maximum startup jitter in milliseconds for sync connections (default: 10000 = 10 seconds) - /// Set to 0 to disable jitter (useful for testing) - #[arg(long, env = "NGIT_SYNC_STARTUP_JITTER_MS", default_value_t = 10_000)] - pub sync_startup_jitter_ms: u64, - /// Interval in seconds for checking disconnected relays and attempting reconnection (default: 60) /// Set to lower value for faster reconnection testing #[arg(long, env = "NGIT_SYNC_DISCONNECT_CHECK_INTERVAL_SECS", default_value_t = 60)] @@ -178,10 +161,6 @@ impl Config { metrics_top_n_repos: 10, sync_bootstrap_relay_url: None, sync_max_backoff_secs: 3600, - sync_startup_delay_secs: 30, - sync_reconnect_delay_secs: 10, - sync_reconnect_lookback_days: 3, - sync_startup_jitter_ms: 10_000, sync_disconnect_check_interval_secs: 60, sync_base_backoff_secs: 5, } diff --git a/src/http/nip11.rs b/src/http/nip11.rs index 19d482f..8c18dde 100644 --- a/src/http/nip11.rs +++ b/src/http/nip11.rs @@ -107,10 +107,6 @@ mod tests { metrics_top_n_repos: 10, sync_bootstrap_relay_url: None, sync_max_backoff_secs: 3600, - sync_startup_delay_secs: 30, - sync_reconnect_delay_secs: 10, - sync_reconnect_lookback_days: 3, - sync_startup_jitter_ms: 10_000, sync_disconnect_check_interval_secs: 60, sync_base_backoff_secs: 5, }; @@ -149,10 +145,6 @@ mod tests { metrics_top_n_repos: 10, sync_bootstrap_relay_url: None, sync_max_backoff_secs: 3600, - sync_startup_delay_secs: 30, - sync_reconnect_delay_secs: 10, - sync_reconnect_lookback_days: 3, - sync_startup_jitter_ms: 10_000, sync_disconnect_check_interval_secs: 60, sync_base_backoff_secs: 5, }; -- cgit v1.2.3