remove docs archive

1 files changed, 0 insertions, 248 deletions

diff --git a/docs/archive/2025-11-04-phase2-test-migration.md b/docs/archive/2025-11-04-phase2-test-migration.md
deleted file mode 100644
index 8728124..0000000
--- a/docs/archive/2025-11-04-phase2-test-migration.md
+++ /dev/null
@@ -1,248 +0,0 @@
-# Phase 2 Complete: Migration and Cleanup
-
-**Date:** November 4, 2025  
-**Status:** ✅ COMPLETE  
-**Duration:** ~45 minutes
-
----
-
-## Objective
-
-Clean up legacy test infrastructure and migrate announcement tests to new TestRelay fixture pattern.
-
----
-
-## What Was Accomplished
-
-### Task 1: Migrated announcement_tests.rs ✅
-
-**Created:** `tests/nip34_announcements.rs` (530 lines)
-
-**Improvements:**
-- Uses TestRelay fixture for automatic relay lifecycle
-- Each test gets isolated relay instance with random port
-- Proper domain configuration (NGIT_DOMAIN set to match bind address)
-- Pure Rust, no manual relay management
-- All 13 tests passing (100%)
-
-**Tests migrated:**
-1. ✅ test_relay_accepts_connection
-2. ✅ test_accepts_valid_announcement
-3. ✅ test_rejects_announcement_without_clone
-4. ✅ test_rejects_announcement_without_relay
-5. ✅ test_rejects_announcement_for_other_service
-6. ✅ test_accepts_valid_state
-7. ✅ test_accepts_state_with_multiple_branches
-8. ✅ test_rejects_state_without_identifier
-9. ✅ test_query_announcements
-10. ✅ test_query_states
-11. ✅ test_duplicate_announcement
-
-**API Updates:**
-- Updated to nostr-sdk 0.43 API:
-  - `TagKind::D` → `TagKind::d()` (method call)
-  - `EventBuilder::new(kind, content, tags)` → `EventBuilder::new(kind, content).tags(tags)`
-  - `TagKind::Custom("clone")` → `TagKind::Clone`
-  - `TagKind::Relays` (unchanged)
-
-### Task 2: Deleted Legacy Files ✅
-
-**Deleted:**
-- `tests/announcement_tests.rs` (314 lines) - replaced by nip34_announcements.rs
-- `test_relay.sh` (40 lines) - no longer needed
-
-**Rationale:**
-- Replaced by pure Rust integration tests
-- No shell scripts needed
-- Automatic relay management
-- Better developer experience
-
-### Task 3: Updated Documentation ✅
-
-**Updated:** `README.md`
-- Added nip34_announcements test documentation
-- Documented how to run all integration tests
-- Updated test commands
-
----
-
-## Test Results
-
-### Before Migration
-```
-tests/announcement_tests.rs: 13 tests (manual relay required)
-test_relay.sh: Shell script for manual testing
-```
-
-### After Migration
-```
-tests/nip34_announcements.rs: 13 tests (automatic relay)
-All tests passing: 12 passed; 0 failed; 1 ignored
-```
-
-### Combined Test Suite
-```bash
-$ nix develop -c cargo test --test nip01_compliance --test nip34_announcements
-
-NIP-01 Compliance: 6 passed; 0 failed; 1 ignored
-NIP-34 Announcements: 12 passed; 0 failed; 1 ignored
-
-Total: 18 integration tests, all passing ✅
-```
-
----
-
-## Technical Highlights
-
-### 1. TestRelay Domain Configuration
-
-**Problem:** Relay was rejecting announcements because domain didn't match
-
-**Solution:** Set `NGIT_DOMAIN` environment variable to match bind address
-
-```rust
-.env("NGIT_DOMAIN", &bind_address) // e.g., "127.0.0.1:34853"
-```
-
-Now announcements with matching clone URLs and relays are accepted.
-
-### 2. Helper Function Pattern
-
-Created `connect_to_relay(url: &str)` helper to reduce boilerplate:
-
-```rust
-async fn connect_to_relay(url: &str) -> WebSocketStream<...> {
-    let (ws, _) = connect_async(url).await.expect("Failed to connect");
-    ws
-}
-```
-
-### 3. Event Builder API Migration
-
-Updated from nostr-sdk 0.35 to 0.43 pattern:
-
-```rust
-// Old (0.35)
-EventBuilder::new(kind, content, tags).sign_with_keys(keys)
-
-// New (0.43)
-EventBuilder::new(kind, content).tags(tags).sign_with_keys(keys)
-```
-
----
-
-## Files Created/Modified
-
-**Created:**
-1. `tests/nip34_announcements.rs` - New integration tests (530 lines)
-2. `work/phase2-plan.md` - Planning document
-3. `work/phase2-complete.md` - This file
-
-**Modified:**
-1. `tests/common/relay.rs` - Added NGIT_DOMAIN env var, domain() method
-2. `README.md` - Updated test documentation
-3. `Cargo.toml` - Added `url` dev dependency (later removed as unnecessary)
-
-**Deleted:**
-1. `tests/announcement_tests.rs` - Old test file
-2. `test_relay.sh` - Shell script
-
----
-
-## Metrics
-
-- **Tests migrated:** 13
-- **Tests passing:** 12 (1 ignored lifecycle test)
-- **Lines of test code:** 530 lines
-- **Test execution time:** ~0.25 seconds
-- **Setup time:** 0 seconds (automatic)
-- **Shell scripts eliminated:** 1
-
----
-
-## Benefits Realized
-
-### For Developers
-- Simple `cargo test` workflow
-- No manual relay management
-- Fast test execution
-- Automatic cleanup
-- Better error messages
-
-### For CI/CD
-- Reliable automated testing
-- No external dependencies
-- Parallel test support
-- Clean test isolation
-- No port conflicts
-
-### For Maintenance
-- Pure Rust (no shell scripts)
-- Consistent test patterns
-- Easy to extend
-- Well-documented
-- Single source of truth for test fixtures
-
----
-
-## Next Steps (Phase 3)
-
-From original plan:
-
-1. **Update Documentation**
-   - Create `docs/how-to/test-compliance.md`
-   - Update `docs/reference/test-strategy.md`
-   - Document the testing approach
-
-2. **Consider Additional Tests**
-   - More GRASP-01 compliance tests
-   - Edge cases
-   - Performance tests
-
-3. **Cleanup**
-   - Archive session notes
-   - Update CHANGELOG.md
-   - Final verification
-
----
-
-## Validation
-
-All Phase 2 acceptance criteria met:
-
-- ✅ All announcement tests migrated to new pattern
-- ✅ All migrated tests passing (12/12 = 100%)
-- ✅ test_relay.sh deleted
-- ✅ announcement_tests.rs deleted
-- ✅ Documentation updated
-- ✅ No references to old files remain
-- ✅ Pure Rust workflow
-- ✅ Automatic relay management
-
----
-
-## Commands for Verification
-
-```bash
-# Run all integration tests
-nix develop -c cargo test --test nip01_compliance --test nip34_announcements
-
-# Verify old files deleted
-ls tests/announcement_tests.rs  # Should not exist
-ls test_relay.sh               # Should not exist
-
-# Verify new tests exist
-ls tests/nip34_announcements.rs  # Should exist
-
-# Check test count
-nix develop -c cargo test --test nip34_announcements -- --list
-# Should show 13 tests
-```
-
----
-
-**Status:** ✅ Phase 2 Complete
-
-**Recommendation:** Proceed to Phase 3 (Documentation) or mark project complete
-
-**Confidence:** High - All tests passing, clean implementation, no legacy code