diff options
| author | DanConwayDev <DanConwayDev@protonmail.com> | 2026-01-09 22:01:36 +0000 |
|---|---|---|
| committer | DanConwayDev <DanConwayDev@protonmail.com> | 2026-01-09 22:01:36 +0000 |
| commit | d5a15c53db5d232173d7fb5379ce047dcee30a14 (patch) | |
| tree | 391e7ace12fde60753bbfe7affad2694dd6933c8 /src | |
| parent | 5570b9631e03c077faa95fbf1f068a4360d25bd7 (diff) | |
fix: downgrade EOSE race condition warning to debug level
During relay disconnect, EOSE messages may arrive after the relay has
been removed from pending_sync_index. This creates a benign race
condition that was logged as a warning.
Changes:
- Downgrade from warn! to debug! in handle_eose() (src/sync/mod.rs:632)
- Add clarifying comment explaining this occurs during disconnect
- Update message to indicate this is expected behavior
Discovered via production sync testing against wss://git.shakespeare.diy
Diffstat (limited to 'src')
| -rw-r--r-- | src/sync/mod.rs | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/sync/mod.rs b/src/sync/mod.rs index 8b5e1c3..6437ee1 100644 --- a/src/sync/mod.rs +++ b/src/sync/mod.rs | |||
| @@ -628,10 +628,11 @@ impl SyncManager { | |||
| 628 | let mut pending = self.pending_sync_index.write().await; | 628 | let mut pending = self.pending_sync_index.write().await; |
| 629 | 629 | ||
| 630 | let Some(batches) = pending.get_mut(relay_url) else { | 630 | let Some(batches) = pending.get_mut(relay_url) else { |
| 631 | tracing::warn!( | 631 | // This can happen during disconnect if EOSE arrives after relay cleanup |
| 632 | tracing::debug!( | ||
| 632 | relay = %relay_url, | 633 | relay = %relay_url, |
| 633 | sub_id = %sub_id, | 634 | sub_id = %sub_id, |
| 634 | "EOSE received for unknown relay" | 635 | "EOSE received for unknown relay (likely during disconnect)" |
| 635 | ); | 636 | ); |
| 636 | return; | 637 | return; |
| 637 | }; | 638 | }; |