replace tests to use grasp-audit lib as much as possible

1 files changed, 28 insertions, 52 deletions

diff --git a/tests/nip01_compliance.rs b/tests/nip01_compliance.rs
index 05957fd..4cb2af4 100644
--- a/tests/nip01_compliance.rs
+++ b/tests/nip01_compliance.rs
@@ -1,14 +1,13 @@
 //! NIP-01 Compliance Integration Tests
 //!
-//! These tests verify that ngit-grasp relay implements NIP-01 correctly
-//! by using the grasp-audit library to run compliance tests.
+//! Tests ngit-grasp relay's NIP-01 compliance using grasp-audit library.
+//! Avoids code duplication by delegating to grasp-audit's test suite.
 //!
 //! # Test Strategy
 //!
-//! - Uses grasp-audit as a library (not CLI)
-//! - Automatically manages relay lifecycle
-//! - Reuses test specs from grasp-audit (single source of truth)
-//! - Pure Rust, no shell scripts
+//! - Uses TestRelay fixture for ngit-grasp relay lifecycle management
+//! - Uses grasp-audit's Nip01SmokeTests for actual test logic
+//! - Minimal duplication - single source of truth in grasp-audit
 //!
 //! # Running Tests
 //!
@@ -30,17 +29,20 @@ use grasp_audit::*;
 
 /// Test NIP-01 smoke tests against ngit-grasp relay
 ///
-/// This test:
-/// 1. Starts a fresh ngit-grasp relay instance
-/// 2. Runs all NIP-01 smoke tests from grasp-audit
-/// 3. Verifies all tests pass
-/// 4. Shuts down the relay
+/// This test runs all NIP-01 smoke tests from grasp-audit against
+/// the ngit-grasp relay implementation.
+///
+/// Tests cover:
+/// - WebSocket connection
+/// - Event send/receive
+/// - Subscriptions (REQ/CLOSE)
+/// - Event validation (signature, ID)
 #[tokio::test]
 async fn test_nip01_smoke() {
     // Start test relay
     let relay = TestRelay::start().await;
 
-    // Create audit client in CI mode (isolated, no cleanup needed)
+    // Create audit client in CI mode (isolated testing)
     let config = AuditConfig::ci();
     let client = AuditClient::new(relay.url(), config)
         .await
@@ -64,34 +66,12 @@ async fn test_nip01_smoke() {
     );
 }
 
-/// Test individual NIP-01 tests can be run separately
-///
-/// This demonstrates that we can run individual tests from the specs
-/// for more granular testing or debugging.
-#[tokio::test]
-async fn test_nip01_individual_tests() {
-    use grasp_audit::specs::grasp01::Nip01SmokeTests;
-
-    let relay = TestRelay::start().await;
-    let config = AuditConfig::ci();
-    let client = AuditClient::new(relay.url(), config)
-        .await
-        .expect("Failed to create audit client");
-
-    // We can't call private methods, so we'll run the full suite
-    // This test is mainly to show the pattern
-    let all_results = Nip01SmokeTests::run_all(&client).await;
-
-    relay.stop().await;
-
-    // Verify
-    assert!(all_results.all_passed());
-}
-
-/// Test that relay rejects invalid events
+/// Test that relay properly validates events
 ///
-/// This is a critical security test - we want to ensure the relay
-/// properly validates events before accepting them.
+/// Critical security test - ensures relay validates:
+/// - Event signatures
+/// - Event IDs
+/// - Other NIP-01 requirements
 #[tokio::test]
 async fn test_relay_validates_events() {
     let relay = TestRelay::start().await;
@@ -100,29 +80,29 @@ async fn test_relay_validates_events() {
         .await
         .expect("Failed to create audit client");
 
-    // The validation tests are part of the smoke tests
+    // Run smoke tests which include validation tests
     let results = specs::Nip01SmokeTests::run_all(&client).await;
 
-    // Check that validation tests exist and pass
+    relay.stop().await;
+
+    // Filter to validation tests
     let validation_tests: Vec<_> = results
         .results
         .iter()
-        .filter(|t| t.spec_ref.contains("validation"))
+        .filter(|t| t.name.contains("reject") || t.name.contains("invalid"))
         .collect();
 
-    relay.stop().await;
-
     // Should have validation tests
     assert!(
         !validation_tests.is_empty(),
-        "No validation tests found in NIP-01 smoke tests"
+        "No validation tests found (these are critical for security)"
     );
 
     // All validation tests should pass
     for test in validation_tests {
         assert!(
             test.passed,
-            "Validation test failed: {} - {}",
+            "Validation test failed: {} - {}\nThis is a security issue!",
             test.name,
             test.error.as_deref().unwrap_or("unknown error")
         );
@@ -131,7 +111,7 @@ async fn test_relay_validates_events() {
 
 /// Test relay lifecycle management
 ///
-/// Ensures our test fixture properly manages relay lifecycle
+/// Verifies TestRelay fixture properly manages relay lifecycle
 #[tokio::test]
 async fn test_relay_lifecycle() {
     // Start relay
@@ -148,15 +128,11 @@ async fn test_relay_lifecycle() {
 
     // Stop relay
     relay.stop().await;
-
-    // Note: We can't easily verify disconnection without modifying grasp-audit
-    // to expose connection state after relay shutdown. That's okay - the
-    // important part is that the relay starts and stops cleanly.
 }
 
 /// Test multiple relays can run in parallel
 ///
-/// This ensures our random port selection works correctly
+/// Ensures random port selection avoids conflicts
 #[tokio::test]
 async fn test_parallel_relays() {
     // Start two relays simultaneously