upleb.uk

Public git repos — served from a NIP-34 GRASP relay at git.upleb.uk

summaryrefslogtreecommitdiff
path: root/grasp-audit/src/specs/grasp01/push_authorization.rs
blob: 5545b1ad2209431a4f0dd3028b68cb5366107bb4 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
//! GRASP-01 Push Authorization Tests
//!
//! Tests that verify push authorization works correctly according to GRASP-01:
//! "MUST accept pushes via this service that match the latest repo state announcement
//! on the relay, respecting the recursive maintainer set."
//!
//! ## Test Coverage
//!
//! - Push authorized when state event matches commit being pushed
//! - Push rejected when no state event exists
//! - Push rejected when state event has different commit
//!
//! ## Running Tests
//!
//! ```bash
//! cd grasp-audit && nix develop -c bash test-ngit-relay.sh --mode test
//! ```

use crate::{AuditClient, FixtureKind, TestContext, TestResult};
use nostr_sdk::prelude::*;
use std::fs;
use std::path::{Path, PathBuf};
use std::process::Command;

/// Test suite for Push Authorization operations
pub struct PushAuthorizationTests;

/// Helper to clone a repository and return the path
fn clone_repo(
    relay_domain: &str,
    npub: &str,
    repo_id: &str,
) -> Result<std::path::PathBuf, String> {
    let temp_base = std::env::temp_dir();
    let clone_dir_name = format!("grasp-push-test-{}", uuid::Uuid::new_v4());
    let clone_path = temp_base.join(&clone_dir_name);
    let _ = fs::remove_dir_all(&clone_path);

    let clone_url = format!("http://{}/{}/{}.git", relay_domain, npub, repo_id);
    let output = Command::new("git")
        .args(["clone", &clone_url, clone_path.to_str().unwrap()])
        .env("GIT_TERMINAL_PROMPT", "0")
        .output()
        .map_err(|e| format!("Failed to execute git clone: {}", e))?;

    if !output.status.success() {
        let stderr = String::from_utf8_lossy(&output.stderr);
        return Err(format!("Git clone failed: {}", stderr));
    }

    // Configure git user
    let _ = Command::new("git")
        .args(["config", "user.email", "test@grasp-audit.local"])
        .current_dir(&clone_path)
        .output();
    let _ = Command::new("git")
        .args(["config", "user.name", "GRASP Audit Test"])
        .current_dir(&clone_path)
        .output();

    Ok(clone_path)
}

/// Helper to create a commit and return the hash
fn create_commit(clone_path: &Path, message: &str) -> Result<String, String> {
    let test_file = clone_path.join(format!("test-{}.txt", uuid::Uuid::new_v4()));
    fs::write(&test_file, message).map_err(|e| format!("Failed to write file: {}", e))?;

    let filename = test_file.file_name().unwrap().to_str().unwrap();
    let output = Command::new("git")
        .args(["add", filename])
        .current_dir(clone_path)
        .output()
        .map_err(|e| format!("Git add failed: {}", e))?;

    if !output.status.success() {
        return Err("Git add failed".to_string());
    }

    let output = Command::new("git")
        .args(["commit", "-m", message])
        .current_dir(clone_path)
        .output()
        .map_err(|e| format!("Git commit failed: {}", e))?;

    if !output.status.success() {
        return Err("Git commit failed".to_string());
    }

    let output = Command::new("git")
        .args(["rev-parse", "HEAD"])
        .current_dir(clone_path)
        .output()
        .map_err(|e| format!("Git rev-parse failed: {}", e))?;

    if !output.status.success() {
        return Err("Failed to get commit hash".to_string());
    }

    Ok(String::from_utf8_lossy(&output.stdout).trim().to_string())
}

/// Helper to create a deterministic commit (for fixtures)
/// Uses fixed author/committer dates and disables GPG signing to ensure consistent hash
pub fn create_deterministic_commit(clone_path: &Path, message: &str) -> Result<String, String> {
    let test_file = clone_path.join("test.txt");
    fs::write(&test_file, message).map_err(|e| format!("Failed to write file: {}", e))?;

    let output = Command::new("git")
        .args(["add", "test.txt"])
        .current_dir(clone_path)
        .output()
        .map_err(|e| format!("Git add failed: {}", e))?;

    if !output.status.success() {
        return Err("Git add failed".to_string());
    }

    // Create deterministic commit with fixed dates and GPG disabled
    let output = Command::new("git")
        .args([
            "-c", "commit.gpgsign=false",
            "commit",
            "-m", message,
        ])
        .env("GIT_AUTHOR_DATE", "2024-01-01T00:00:00Z")
        .env("GIT_COMMITTER_DATE", "2024-01-01T00:00:00Z")
        .current_dir(clone_path)
        .output()
        .map_err(|e| format!("Git commit failed: {}", e))?;

    if !output.status.success() {
        let stderr = String::from_utf8_lossy(&output.stderr);
        return Err(format!("Git commit failed: {}", stderr));
    }

    let output = Command::new("git")
        .args(["rev-parse", "HEAD"])
        .current_dir(clone_path)
        .output()
        .map_err(|e| format!("Git rev-parse failed: {}", e))?;

    if !output.status.success() {
        return Err("Failed to get commit hash".to_string());
    }

    Ok(String::from_utf8_lossy(&output.stdout).trim().to_string())
}

/// Repository setup with deterministic commit
/// This struct holds all the data needed for push authorization tests
pub struct RepoSetup {
    pub clone_path: PathBuf,
    pub repo_id: String,
    pub npub: String,
    pub commit_hash: String,
}

impl Drop for RepoSetup {
    fn drop(&mut self) {
        let _ = fs::remove_dir_all(&self.clone_path);
    }
}

/// Helper function to set up a repository with deterministic commit
///
/// This performs all the common setup steps needed for push authorization tests:
/// 1. Gets RepoState fixture (repo announcement + state event with deterministic commit)
/// 2. Extracts repo_id and npub
/// 3. Verifies repo exists on disk
/// 4. Clones the repository
/// 5. Creates deterministic commit locally
/// 6. Verifies commit hash matches expected
/// 7. Creates and checks out main branch
/// 8. Pushes the commit so the grasp server has the state in the state event
///
/// Returns RepoSetup which auto-cleans up the clone_path on drop
pub async fn setup_repo_with_deterministic_commit(
    client: &AuditClient,
    git_data_dir: &Path,
    relay_domain: &str,
) -> Result<RepoSetup, String> {
    use crate::DETERMINISTIC_COMMIT_HASH;
    
    let ctx = TestContext::new(client);

    // Get RepoState fixture (includes repo announcement and state event with deterministic commit)
    let state_event = ctx.get_fixture(FixtureKind::RepoState).await
        .map_err(|e| format!("Failed to create repo state fixture: {}", e))?;

    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    // Extract repo_id from state event
    let repo_id = state_event.tags.iter().find(|t| t.kind() == TagKind::d())
        .and_then(|t| t.content())
        .ok_or("Missing repo_id")?
        .to_string();
    let npub = state_event.pubkey.to_bech32()
        .map_err(|e| format!("Failed to convert pubkey to bech32: {}", e))?;

    // Verify repo exists
    let repo_path = git_data_dir.join(&npub).join(format!("{}.git", repo_id));
    if !repo_path.exists() {
        return Err(format!("Repo not found: {}", repo_path.display()));
    }

    // Clone repo
    let clone_path = clone_repo(relay_domain, &npub, &repo_id)?;

    // Create deterministic commit locally (this will be the root commit with no parent)
    let commit_hash = create_deterministic_commit(&clone_path, "Initial commit")
        .map_err(|e| {
            let _ = fs::remove_dir_all(&clone_path);
            e
        })?;

    // Verify commit hash matches expected deterministic hash
    if commit_hash != DETERMINISTIC_COMMIT_HASH {
        let _ = fs::remove_dir_all(&clone_path);
        return Err(format!(
            "Commit hash mismatch: got {}, expected {}",
            commit_hash, DETERMINISTIC_COMMIT_HASH
        ));
    }

    // Create main branch pointing to our deterministic commit
    let branch_output = Command::new("git")
        .args(["branch", "main"])
        .current_dir(&clone_path)
        .output()
        .map_err(|e| {
            let _ = fs::remove_dir_all(&clone_path);
            format!("Failed to create main branch: {}", e)
        })?;
    
    if !branch_output.status.success() {
        let _ = fs::remove_dir_all(&clone_path);
        return Err(format!(
            "Failed to create main branch: {}",
            String::from_utf8_lossy(&branch_output.stderr)
        ));
    }

    // Checkout main branch
    let checkout_output = Command::new("git")
        .args(["checkout", "main"])
        .current_dir(&clone_path)
        .output()
        .map_err(|e| {
            let _ = fs::remove_dir_all(&clone_path);
            format!("Failed to checkout main branch: {}", e)
        })?;
    
    if !checkout_output.status.success() {
        let _ = fs::remove_dir_all(&clone_path);
        return Err(format!(
            "Failed to checkout main branch: {}",
            String::from_utf8_lossy(&checkout_output.stderr)
        ));
    }

    // Push the commit to the server so the bare repo matches the state event
    let push_output = Command::new("git")
        .args(["push", "origin", "main"])
        .current_dir(&clone_path)
        .env("GIT_TERMINAL_PROMPT", "0")
        .output()
        .map_err(|e| {
            let _ = fs::remove_dir_all(&clone_path);
            format!("Failed to push to server: {}", e)
        })?;
    
    if !push_output.status.success() {
        let _ = fs::remove_dir_all(&clone_path);
        return Err(format!(
            "Failed to push to server: {}",
            String::from_utf8_lossy(&push_output.stderr)
        ));
    }

    Ok(RepoSetup {
        clone_path,
        repo_id,
        npub,
        commit_hash,
    })
}

/// Helper to attempt a push and return success/failure
fn try_push(clone_path: &Path) -> Result<bool, String> {
    let output = Command::new("git")
        .args(["push", "origin", "main"])
        .current_dir(clone_path)
        .env("GIT_TERMINAL_PROMPT", "0")
        .output()
        .map_err(|e| format!("Failed to execute git push: {}", e))?;

    Ok(output.status.success())
}

impl PushAuthorizationTests {
    /// Test that push is authorized when state event matches the commit
    ///
    /// GRASP-01: "MUST accept pushes via this service that match the latest
    /// repo state announcement on the relay"
    pub async fn test_push_authorized_by_owner_state(
        client: &AuditClient,
        git_data_dir: &Path,
        relay_domain: &str,
    ) -> TestResult {
        let test_name = "test_push_authorized_by_owner_state";

        // this setup is exactly what we are testing
        match setup_repo_with_deterministic_commit(client, git_data_dir, relay_domain).await {
            Ok(_) => {
                return TestResult::new(test_name, "GRASP-01", "Push authorized with matching state").pass()
            },
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", "Push authorized with matching state")
                    .fail(&format!("Failed: {}", e))
            }
        };
    }

    /// Test that push is rejected when no state event exists
    pub async fn test_push_rejected_without_state_event(
        client: &AuditClient,
        git_data_dir: &Path,
        relay_domain: &str,
    ) -> TestResult {
        let test_name = "test_push_rejected_without_state_event";
        let ctx = TestContext::new(client);

        // Create repository (no state event)
        let repo = match ctx.get_fixture(FixtureKind::ValidRepo).await {
            Ok(r) => r,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", "Push rejected without state event")
                    .fail(&format!("Failed to create repo: {}", e))
            }
        };

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        let repo_id = repo.tags.iter().find(|t| t.kind() == TagKind::d())
            .and_then(|t| t.content()).unwrap().to_string();
        let npub = repo.pubkey.to_bech32().unwrap();

        let repo_path = git_data_dir.join(&npub).join(format!("{}.git", repo_id));
        if !repo_path.exists() {
            return TestResult::new(test_name, "GRASP-01", "Push rejected without state event")
                .fail(&format!("Repo not found: {}", repo_path.display()));
        }

        // Clone and create commit
        let clone_path = match clone_repo(relay_domain, &npub, &repo_id) {
            Ok(p) => p,
            Err(e) => return TestResult::new(test_name, "GRASP-01", "Push rejected without state event").fail(&e),
        };
        let cleanup = || { let _ = fs::remove_dir_all(&clone_path); };

        if let Err(e) = create_commit(&clone_path, "Unauthorized commit") {
            cleanup();
            return TestResult::new(test_name, "GRASP-01", "Push rejected without state event").fail(&e);
        }

        // Do NOT publish state event - push should be rejected
        let push_result = try_push(&clone_path);
        cleanup();

        match push_result {
            Ok(false) => TestResult::new(test_name, "GRASP-01", "Push rejected without state event").pass(),
            Ok(true) => TestResult::new(test_name, "GRASP-01", "Push rejected without state event").fail("Push accepted but should be rejected"),
            Err(e) => TestResult::new(test_name, "GRASP-01", "Push rejected without state event").fail(&e),
        }
    }

    /// Test that push is rejected when commit doesn't match state event
    ///
    /// This test verifies that the relay enforces state event authorization.
    /// The state event (from fixture) points to the deterministic commit which is
    /// already on the server. We create a new commit locally and try to push it.
    /// The push should be rejected because the new commit doesn't match what the
    /// state event announces.
    pub async fn test_push_rejected_wrong_commit(
        client: &AuditClient,
        git_data_dir: &Path,
        relay_domain: &str,
    ) -> TestResult {
        let test_name = "test_push_rejected_wrong_commit";

        // Set up repository with deterministic commit
        // This creates a state event pointing to DETERMINISTIC_COMMIT_HASH and pushes that commit
        let setup = match setup_repo_with_deterministic_commit(client, git_data_dir, relay_domain).await {
            Ok(s) => s,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", "Push rejected when commit not in state event")
                    .fail(&format!("Setup failed: {}", e))
            }
        };

        // Create a new commit locally - this is NOT announced in any state event
        let new_commit = match create_commit(&setup.clone_path, "Unauthorized commit") {
            Ok(h) => h,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", "Push rejected when commit not in state event")
                    .fail(&format!("Failed to create commit: {}", e))
            }
        };

        // Try to push the new commit
        // This should be REJECTED because:
        // - The state event still points to the deterministic commit (setup.commit_hash)
        // - We're trying to push new_commit which is different
        // - The relay MUST reject pushes that don't match the announced state
        let push_result = try_push(&setup.clone_path);

        match push_result {
            Ok(false) => TestResult::new(test_name, "GRASP-01", "Push rejected when commit not in state event").pass(),
            Ok(true) => TestResult::new(test_name, "GRASP-01", "Push rejected when commit not in state event")
                .fail(&format!(
                    "Push accepted but should be rejected. State event points to {}, but pushed {}",
                    setup.commit_hash, new_commit
                )),
            Err(e) => TestResult::new(test_name, "GRASP-01", "Push rejected when commit not in state event").fail(&e),
        }
    }

    /// Test that latest state event is used for authorization
    ///
    /// GRASP-01 requires that the relay use the LATEST state event (by created_at
    /// timestamp) when determining push authorization. This test verifies that
    /// a newer state event takes precedence over an older one.
    ///
    /// Scenario:
    /// 1. Owner creates repo with maintainer
    /// 2. Owner publishes state event for commit_a at t=100 (older)
    /// 3. Maintainer publishes state event for commit_b at t=200 (newer)
    /// 4. Push commit_b should be ACCEPTED (newer timestamp wins)
    /// 5. Push commit_a should be REJECTED (older state event superseded)
    pub async fn test_latest_state_event_used(
        client: &AuditClient,
        git_data_dir: &Path,
        relay_domain: &str,
    ) -> TestResult {
        let test_name = "test_latest_state_event_used";
        let description = "Latest state event takes precedence";

        // 1. Generate maintainer keypair
        let maintainer_keys = Keys::generate();
        let maintainer_pubkey = maintainer_keys.public_key().to_hex();

        // 2. Owner creates repo with maintainer
        let repo_event = match client
            .create_repo_announcement_with_maintainers(test_name, &[maintainer_pubkey.clone()])
            .await
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to create repo with maintainers: {}", e))
            }
        };

        // Send the owner's repo event
        if let Err(e) = client.send_event(repo_event.clone()).await {
            return TestResult::new(test_name, "GRASP-01", description)
                .fail(&format!("Failed to send owner repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Extract repo details
        let repo_id = match repo_event
            .tags
            .iter()
            .find(|t| t.kind() == TagKind::d())
            .and_then(|t| t.content())
        {
            Some(id) => id.to_string(),
            None => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail("Repository event missing d tag")
            }
        };

        // Get relay URL for maintainer's repo announcement
        let relay_url = match client.relay_url().await {
            Ok(u) => u,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to get relay URL: {}", e))
            }
        };
        let http_url = relay_url
            .replace("ws://", "http://")
            .replace("wss://", "https://");
        let maintainer_npub = match maintainer_keys.public_key().to_bech32() {
            Ok(n) => n,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to convert maintainer pubkey to npub: {}", e))
            }
        };

        // 3. Maintainer creates their own repo announcement (same d-tag)
        let maintainer_repo_event = match client
            .event_builder(
                Kind::GitRepoAnnouncement,
                format!("Maintainer's view of {} repository", test_name),
            )
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("name"),
                vec![format!("{} Test Repository (Maintainer)", test_name)],
            ))
            .tag(Tag::custom(
                TagKind::custom("clone"),
                vec![format!("{}/{}/{}.git", http_url, maintainer_npub, repo_id)],
            ))
            .tag(Tag::custom(
                TagKind::custom("relays"),
                vec![relay_url.clone()],
            ))
            .build(&maintainer_keys)
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to build maintainer repo event: {}", e))
            }
        };

        if let Err(e) = client.client().send_event(&maintainer_repo_event).await {
            return TestResult::new(test_name, "GRASP-01", description)
                .fail(&format!("Failed to send maintainer repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Verify maintainer's repo was created
        let maintainer_repo_path = git_data_dir
            .join(&maintainer_npub)
            .join(format!("{}.git", repo_id));
        if !maintainer_repo_path.exists() {
            return TestResult::new(test_name, "GRASP-01", description).fail(&format!(
                "Maintainer repo not created at: {}",
                maintainer_repo_path.display()
            ));
        }

        // 4. Clone maintainer's repo
        let clone_path = match clone_repo(relay_domain, &maintainer_npub, &repo_id) {
            Ok(p) => p,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to clone maintainer repo: {}", e))
            }
        };

        // 5. Create first commit (commit_a) - this will be the one with OLDER timestamp
        let commit_a = match create_commit(&clone_path, "Commit A - older state") {
            Ok(h) => h,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to create commit_a: {}", e));
            }
        };

        // 6. Create second commit (commit_b) - this will be the one with NEWER timestamp
        let commit_b = match create_commit(&clone_path, "Commit B - newer state") {
            Ok(h) => h,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to create commit_b: {}", e));
            }
        };

        // 7. Calculate timestamps: older_timestamp (100 seconds ago) and newer_timestamp (now)
        let base_time = Timestamp::now().as_u64();
        let older_timestamp = Timestamp::from(base_time - 100); // 100 seconds ago
        let newer_timestamp = Timestamp::from(base_time);        // now

        // 8. Owner publishes state event for commit_a at OLDER timestamp
        let owner_state_event = match client
            .event_builder(Kind::Custom(30618), "")
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("refs/heads/main"),
                vec![commit_a.clone()],
            ))
            .custom_time(older_timestamp)
            .build(client.keys())
        {
            Ok(e) => e,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to build owner state event: {}", e));
            }
        };

        if let Err(e) = client.client().send_event(&owner_state_event).await {
            let _ = fs::remove_dir_all(&clone_path);
            return TestResult::new(test_name, "GRASP-01", description)
                .fail(&format!("Failed to send owner state event: {}", e));
        }

        // 9. Maintainer publishes state event for commit_b at NEWER timestamp
        let maintainer_state_event = match client
            .event_builder(Kind::Custom(30618), "")
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("refs/heads/main"),
                vec![commit_b.clone()],
            ))
            .custom_time(newer_timestamp)
            .build(&maintainer_keys)
        {
            Ok(e) => e,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to build maintainer state event: {}", e));
            }
        };

        if let Err(e) = client.client().send_event(&maintainer_state_event).await {
            let _ = fs::remove_dir_all(&clone_path);
            return TestResult::new(test_name, "GRASP-01", description)
                .fail(&format!("Failed to send maintainer state event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // 10. Create and checkout main branch pointing to commit_b (the newer state)
        let branch_output = Command::new("git")
            .args(["branch", "main"])
            .current_dir(&clone_path)
            .output();

        if let Ok(output) = branch_output {
            if !output.status.success() {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description).fail(&format!(
                    "Failed to create main branch: {}",
                    String::from_utf8_lossy(&output.stderr)
                ));
            }
        }

        let checkout_output = Command::new("git")
            .args(["checkout", "main"])
            .current_dir(&clone_path)
            .output();

        if let Ok(output) = checkout_output {
            if !output.status.success() {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description).fail(&format!(
                    "Failed to checkout main branch: {}",
                    String::from_utf8_lossy(&output.stderr)
                ));
            }
        }

        // 11. Attempt push - should be ACCEPTED because maintainer's newer state event
        // announces commit_b which is now HEAD of main
        let push_result = try_push(&clone_path);
        let _ = fs::remove_dir_all(&clone_path);

        match push_result {
            Ok(true) => TestResult::new(test_name, "GRASP-01", description).pass(),
            Ok(false) => TestResult::new(test_name, "GRASP-01", description).fail(&format!(
                "Push was rejected but should have been accepted. \
                The maintainer published a state event at timestamp {} announcing commit_b ({}). \
                The owner published an older state event at timestamp {} announcing commit_a ({}). \
                The relay should use the NEWER state event (maintainer's) for authorization.",
                newer_timestamp.as_u64(),
                commit_b,
                older_timestamp.as_u64(),
                commit_a
            )),
            Err(e) => {
                TestResult::new(test_name, "GRASP-01", description).fail(&format!("Push error: {}", e))
            }
        }
    }

    /// Test push authorized by direct maintainer state event
    ///
    /// GRASP-01: "respecting the recursive maintainer set"
    /// This tests the first level: direct maintainers listed in the maintainers tag.
    ///
    /// Scenario:
    /// 1. Owner creates repo with `["maintainers", "<maintainer-pubkey>"]` tag
    /// 2. Maintainer creates their own repo announcement (same d-tag)
    /// 3. Maintainer publishes state event with a commit hash
    /// 4. Push to that commit should be ACCEPTED
    pub async fn test_push_authorized_by_direct_maintainer_state(
        client: &AuditClient,
        git_data_dir: &Path,
        relay_domain: &str,
    ) -> TestResult {
        let test_name = "test_push_authorized_by_direct_maintainer_state";

        // 1. Generate maintainer keypair
        let maintainer_keys = Keys::generate();
        let maintainer_pubkey = maintainer_keys.public_key().to_hex();

        // 2. Owner creates repo with maintainer listed
        let repo_event = match client
            .create_repo_announcement_with_maintainers(test_name, &[maintainer_pubkey.clone()])
            .await
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!("Failed to create repo with maintainers: {}", e))
            }
        };

        // Send the owner's repo event
        if let Err(e) = client.send_event(repo_event.clone()).await {
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by direct maintainer state event",
            )
            .fail(&format!("Failed to send owner repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Extract repo details
        let repo_id = match repo_event
            .tags
            .iter()
            .find(|t| t.kind() == TagKind::d())
            .and_then(|t| t.content())
        {
            Some(id) => id.to_string(),
            None => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail("Repository event missing d tag")
            }
        };

        // Get relay URL for maintainer's repo announcement
        let relay_url = match client.relay_url().await {
            Ok(u) => u,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!("Failed to get relay URL: {}", e))
            }
        };
        let http_url = relay_url
            .replace("ws://", "http://")
            .replace("wss://", "https://");
        let maintainer_npub = match maintainer_keys.public_key().to_bech32() {
            Ok(n) => n,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!("Failed to convert maintainer pubkey to npub: {}", e))
            }
        };

        // 3. Maintainer creates their own repo announcement (same d-tag)
        // This creates a separate repo at maintainer-npub/repo-id.git
        let maintainer_repo_event = match client
            .event_builder(
                Kind::GitRepoAnnouncement,
                format!("Maintainer's view of {} repository", test_name),
            )
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("name"),
                vec![format!("{} Test Repository (Maintainer)", test_name)],
            ))
            .tag(Tag::custom(
                TagKind::custom("clone"),
                vec![format!("{}/{}/{}.git", http_url, maintainer_npub, repo_id)],
            ))
            .tag(Tag::custom(
                TagKind::custom("relays"),
                vec![relay_url.clone()],
            ))
            .build(&maintainer_keys)
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!("Failed to build maintainer repo event: {}", e))
            }
        };

        if let Err(e) = client.client().send_event(&maintainer_repo_event).await {
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by direct maintainer state event",
            )
            .fail(&format!("Failed to send maintainer repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Verify maintainer's repo was created
        let maintainer_repo_path = git_data_dir
            .join(&maintainer_npub)
            .join(format!("{}.git", repo_id));
        if !maintainer_repo_path.exists() {
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by direct maintainer state event",
            )
            .fail(&format!(
                "Maintainer repo not created at: {}",
                maintainer_repo_path.display()
            ));
        }

        // 4. Clone maintainer's repo
        let clone_path = match clone_repo(relay_domain, &maintainer_npub, &repo_id) {
            Ok(p) => p,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!("Failed to clone maintainer repo: {}", e))
            }
        };

        // 5. Create deterministic commit
        let commit_hash = match create_deterministic_commit(&clone_path, "Initial commit") {
            Ok(h) => h,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!("Failed to create commit: {}", e));
            }
        };

        // 6. Maintainer publishes state event with commit hash
        let state_event = match client
            .event_builder(Kind::Custom(30618), "")
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("refs/heads/main"),
                vec![commit_hash.clone()],
            ))
            .build(&maintainer_keys)
        {
            Ok(e) => e,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!("Failed to build state event: {}", e));
            }
        };

        if let Err(e) = client.client().send_event(&state_event).await {
            let _ = fs::remove_dir_all(&clone_path);
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by direct maintainer state event",
            )
            .fail(&format!("Failed to send state event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // 7. Create and checkout main branch
        let branch_output = Command::new("git")
            .args(["branch", "main"])
            .current_dir(&clone_path)
            .output();

        if let Ok(output) = branch_output {
            if !output.status.success() {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!(
                    "Failed to create main branch: {}",
                    String::from_utf8_lossy(&output.stderr)
                ));
            }
        }

        let checkout_output = Command::new("git")
            .args(["checkout", "main"])
            .current_dir(&clone_path)
            .output();

        if let Ok(output) = checkout_output {
            if !output.status.success() {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by direct maintainer state event",
                )
                .fail(&format!(
                    "Failed to checkout main branch: {}",
                    String::from_utf8_lossy(&output.stderr)
                ));
            }
        }

        // 8. Attempt push - should be ACCEPTED because maintainer's state event authorizes it
        let push_result = try_push(&clone_path);
        let _ = fs::remove_dir_all(&clone_path);

        match push_result {
            Ok(true) => TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by direct maintainer state event",
            )
            .pass(),
            Ok(false) => TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by direct maintainer state event",
            )
            .fail(&format!(
                "Push was rejected but should have been accepted. \
                The maintainer (pubkey: {}) is listed in the owner's maintainers tag \
                and published a state event announcing commit {}. \
                The relay should authorize pushes matching this state event.",
                maintainer_pubkey, commit_hash
            )),
            Err(e) => TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by direct maintainer state event",
            )
            .fail(&format!("Push error: {}", e)),
        }
    }

    /// Test push authorized by recursive maintainer state event
    ///
    /// GRASP-01: "respecting the recursive maintainer set"
    /// This tests recursive maintainer chains: Owner -> MaintainerA -> MaintainerB
    ///
    /// Scenario:
    /// 1. Owner creates repo with `["maintainers", "<maintainerA-pubkey>"]` tag
    /// 2. MaintainerA creates their own repo announcement (same d-tag) with MaintainerB
    /// 3. MaintainerB creates their own repo announcement (same d-tag, no further maintainers)
    /// 4. MaintainerB publishes state event with a commit hash
    /// 5. Push to that commit should be ACCEPTED (recursive maintainer chain)
    pub async fn test_push_authorized_by_recursive_maintainer_state(
        client: &AuditClient,
        git_data_dir: &Path,
        relay_domain: &str,
    ) -> TestResult {
        let test_name = "test_push_authorized_by_recursive_maintainer_state";

        // 1. Generate MaintainerA and MaintainerB keypairs
        let maintainer_a_keys = Keys::generate();
        let maintainer_a_pubkey = maintainer_a_keys.public_key().to_hex();

        let maintainer_b_keys = Keys::generate();
        let maintainer_b_pubkey = maintainer_b_keys.public_key().to_hex();

        // 2. Owner creates repo with MaintainerA listed
        let repo_event = match client
            .create_repo_announcement_with_maintainers(test_name, &[maintainer_a_pubkey.clone()])
            .await
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to create repo with maintainers: {}", e))
            }
        };

        // Send the owner's repo event
        if let Err(e) = client.send_event(repo_event.clone()).await {
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by recursive maintainer state event",
            )
            .fail(&format!("Failed to send owner repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Extract repo details
        let repo_id = match repo_event
            .tags
            .iter()
            .find(|t| t.kind() == TagKind::d())
            .and_then(|t| t.content())
        {
            Some(id) => id.to_string(),
            None => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail("Repository event missing d tag")
            }
        };

        // Get relay URL for maintainers' repo announcements
        let relay_url = match client.relay_url().await {
            Ok(u) => u,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to get relay URL: {}", e))
            }
        };
        let http_url = relay_url
            .replace("ws://", "http://")
            .replace("wss://", "https://");

        let maintainer_a_npub = match maintainer_a_keys.public_key().to_bech32() {
            Ok(n) => n,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to convert maintainer A pubkey to npub: {}", e))
            }
        };

        let maintainer_b_npub = match maintainer_b_keys.public_key().to_bech32() {
            Ok(n) => n,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to convert maintainer B pubkey to npub: {}", e))
            }
        };

        // 3. MaintainerA creates their own repo announcement (same d-tag) with MaintainerB listed
        let maintainer_a_repo_event = match client
            .event_builder(
                Kind::GitRepoAnnouncement,
                format!("MaintainerA's view of {} repository", test_name),
            )
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("name"),
                vec![format!("{} Test Repository (MaintainerA)", test_name)],
            ))
            .tag(Tag::custom(
                TagKind::custom("clone"),
                vec![format!("{}/{}/{}.git", http_url, maintainer_a_npub, repo_id)],
            ))
            .tag(Tag::custom(
                TagKind::custom("relays"),
                vec![relay_url.clone()],
            ))
            .tag(Tag::custom(
                TagKind::custom("maintainers"),
                vec![maintainer_b_pubkey.clone()],
            ))
            .build(&maintainer_a_keys)
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to build maintainer A repo event: {}", e))
            }
        };

        if let Err(e) = client.client().send_event(&maintainer_a_repo_event).await {
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by recursive maintainer state event",
            )
            .fail(&format!("Failed to send maintainer A repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // 4. MaintainerB creates their own repo announcement (same d-tag, no further maintainers)
        let maintainer_b_repo_event = match client
            .event_builder(
                Kind::GitRepoAnnouncement,
                format!("MaintainerB's view of {} repository", test_name),
            )
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("name"),
                vec![format!("{} Test Repository (MaintainerB)", test_name)],
            ))
            .tag(Tag::custom(
                TagKind::custom("clone"),
                vec![format!("{}/{}/{}.git", http_url, maintainer_b_npub, repo_id)],
            ))
            .tag(Tag::custom(
                TagKind::custom("relays"),
                vec![relay_url.clone()],
            ))
            .build(&maintainer_b_keys)
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to build maintainer B repo event: {}", e))
            }
        };

        if let Err(e) = client.client().send_event(&maintainer_b_repo_event).await {
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by recursive maintainer state event",
            )
            .fail(&format!("Failed to send maintainer B repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Verify maintainer B's repo was created
        let maintainer_b_repo_path = git_data_dir
            .join(&maintainer_b_npub)
            .join(format!("{}.git", repo_id));
        if !maintainer_b_repo_path.exists() {
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by recursive maintainer state event",
            )
            .fail(&format!(
                "Maintainer B repo not created at: {}",
                maintainer_b_repo_path.display()
            ));
        }

        // 5. Clone maintainer B's repo
        let clone_path = match clone_repo(relay_domain, &maintainer_b_npub, &repo_id) {
            Ok(p) => p,
            Err(e) => {
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to clone maintainer B repo: {}", e))
            }
        };

        // 6. Create deterministic commit
        let commit_hash = match create_deterministic_commit(&clone_path, "Initial commit") {
            Ok(h) => h,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to create commit: {}", e));
            }
        };

        // 7. MaintainerB publishes state event with commit hash
        let state_event = match client
            .event_builder(Kind::Custom(30618), "")
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("refs/heads/main"),
                vec![commit_hash.clone()],
            ))
            .build(&maintainer_b_keys)
        {
            Ok(e) => e,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!("Failed to build state event: {}", e));
            }
        };

        if let Err(e) = client.client().send_event(&state_event).await {
            let _ = fs::remove_dir_all(&clone_path);
            return TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by recursive maintainer state event",
            )
            .fail(&format!("Failed to send state event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // 8. Create and checkout main branch
        let branch_output = Command::new("git")
            .args(["branch", "main"])
            .current_dir(&clone_path)
            .output();

        if let Ok(output) = branch_output {
            if !output.status.success() {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!(
                    "Failed to create main branch: {}",
                    String::from_utf8_lossy(&output.stderr)
                ));
            }
        }

        let checkout_output = Command::new("git")
            .args(["checkout", "main"])
            .current_dir(&clone_path)
            .output();

        if let Ok(output) = checkout_output {
            if !output.status.success() {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(
                    test_name,
                    "GRASP-01",
                    "Push authorized by recursive maintainer state event",
                )
                .fail(&format!(
                    "Failed to checkout main branch: {}",
                    String::from_utf8_lossy(&output.stderr)
                ));
            }
        }

        // 9. Attempt push - should be ACCEPTED because recursive maintainer chain authorizes it
        // Owner -> MaintainerA -> MaintainerB, and MaintainerB has published the state event
        let push_result = try_push(&clone_path);
        let _ = fs::remove_dir_all(&clone_path);

        match push_result {
            Ok(true) => TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by recursive maintainer state event",
            )
            .pass(),
            Ok(false) => TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by recursive maintainer state event",
            )
            .fail(&format!(
                "Push was rejected but should have been accepted. \
                The recursive maintainer chain is: Owner -> MaintainerA (pubkey: {}) -> MaintainerB (pubkey: {}). \
                MaintainerB published a state event announcing commit {}. \
                The relay should authorize pushes matching this state event through recursive maintainer traversal.",
                maintainer_a_pubkey, maintainer_b_pubkey, commit_hash
            )),
            Err(e) => TestResult::new(
                test_name,
                "GRASP-01",
                "Push authorized by recursive maintainer state event",
            )
            .fail(&format!("Push error: {}", e)),
        }
    }

    /// Test that non-maintainer state event is ignored
    ///
    /// This test verifies that the relay ignores state events from non-maintainers.
    /// We set up a valid repo, then create a rogue state event signed by a different
    /// keypair (not the repo maintainer) that announces a different commit. The push
    /// should be rejected because the rogue state event is not authorized.
    pub async fn test_non_maintainer_state_rejected(
        client: &AuditClient,
        git_data_dir: &Path,
        relay_domain: &str,
    ) -> TestResult {
        let test_name = "test_non_maintainer_state_rejected";

        // Set up repository with deterministic commit (signed by maintainer)
        let setup = match setup_repo_with_deterministic_commit(client, git_data_dir, relay_domain).await {
            Ok(s) => s,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", "Non-maintainer state events ignored")
                    .fail(&format!("Setup failed: {}", e))
            }
        };

        // Create a new commit locally that we want to push
        let new_commit = match create_commit(&setup.clone_path, "New commit to push") {
            Ok(h) => h,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", "Non-maintainer state events ignored")
                    .fail(&format!("Failed to create commit: {}", e))
            }
        };

        // Create a rogue keypair (NOT the maintainer)
        let rogue_keys = Keys::generate();
        
        // Create a rogue state event announcing the new commit
        // This event has the correct repo_id but is signed by a non-maintainer
        let rogue_state = match client
            .event_builder(Kind::Custom(30618), "")
            .tag(Tag::identifier(&setup.repo_id))
            .tag(Tag::custom(
                TagKind::custom("refs/heads/main"),
                vec![new_commit.clone()],
            ))
            .build(&rogue_keys)
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", "Non-maintainer state events ignored")
                    .fail(&format!("Failed to build rogue state event: {}", e))
            }
        };

        // Send the rogue state event using the raw client to bypass AuditClient's key check
        if let Err(e) = client.client().send_event(&rogue_state).await {
            return TestResult::new(test_name, "GRASP-01", "Non-maintainer state events ignored")
                .fail(&format!("Failed to send rogue state event: {}", e));
        }

        // Wait for event to propagate
        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Try to push the new commit
        // This should be REJECTED because:
        // - The rogue state event announces new_commit
        // - But the rogue state event is NOT signed by the maintainer
        // - The relay should ignore the rogue state event
        // - The valid state event (from setup) still points to the deterministic commit
        // - Therefore pushing new_commit should fail
        let push_result = try_push(&setup.clone_path);

        match push_result {
            Ok(false) => TestResult::new(test_name, "GRASP-01", "Non-maintainer state events ignored").pass(),
            Ok(true) => TestResult::new(test_name, "GRASP-01", "Non-maintainer state events ignored")
                .fail(&format!(
                    "Push accepted but should be rejected. A non-maintainer (pubkey: {}) published \
                    a state event announcing commit {}, but the push was accepted. The relay should \
                    only accept state events from maintainers (pubkey: {}).",
                    rogue_keys.public_key(),
                    new_commit,
                    client.public_key()
                )),
            Err(e) => TestResult::new(test_name, "GRASP-01", "Non-maintainer state events ignored").fail(&e),
        }
    }

    /// Test that owner's newer state event beats maintainer's older state event
    ///
    /// GRASP-01 requires that the relay use the LATEST state event (by created_at
    /// timestamp) when determining push authorization. This test is the MIRROR of
    /// test_latest_state_event_used - confirming that timestamp is the deciding factor,
    /// not who authored the state event.
    ///
    /// Scenario:
    /// 1. Owner creates repo with maintainer
    /// 2. Maintainer publishes state event for commit_a at t=100 (older)
    /// 3. Owner publishes state event for commit_b at t=200 (newer)
    /// 4. Push commit_b should be ACCEPTED (owner's newer state wins)
    /// 5. Push commit_a should be REJECTED (maintainer's older state superseded)
    ///
    /// Key difference from test_latest_state_event_used:
    /// - Task 8: Owner=older, Maintainer=newer → Maintainer wins
    /// - Task 9: Maintainer=older, Owner=newer → Owner wins
    /// - **This confirms symmetry**: timestamp is the deciding factor
    pub async fn test_owner_newer_state_beats_maintainer(
        client: &AuditClient,
        git_data_dir: &Path,
        relay_domain: &str,
    ) -> TestResult {
        let test_name = "test_owner_newer_state_beats_maintainer";
        let description = "Owner's newer state event beats maintainer's older state";

        // 1. Generate maintainer keypair
        let maintainer_keys = Keys::generate();
        let maintainer_pubkey = maintainer_keys.public_key().to_hex();

        // 2. Owner creates repo with maintainer
        let repo_event = match client
            .create_repo_announcement_with_maintainers(test_name, &[maintainer_pubkey.clone()])
            .await
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to create repo with maintainers: {}", e))
            }
        };

        // Send the owner's repo event
        if let Err(e) = client.send_event(repo_event.clone()).await {
            return TestResult::new(test_name, "GRASP-01", description)
                .fail(&format!("Failed to send owner repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Extract repo details
        let repo_id = match repo_event
            .tags
            .iter()
            .find(|t| t.kind() == TagKind::d())
            .and_then(|t| t.content())
        {
            Some(id) => id.to_string(),
            None => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail("Repository event missing d tag")
            }
        };

        // Get relay URL for maintainer's repo announcement
        let relay_url = match client.relay_url().await {
            Ok(u) => u,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to get relay URL: {}", e))
            }
        };
        let http_url = relay_url
            .replace("ws://", "http://")
            .replace("wss://", "https://");
        let maintainer_npub = match maintainer_keys.public_key().to_bech32() {
            Ok(n) => n,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to convert maintainer pubkey to npub: {}", e))
            }
        };

        // 3. Maintainer creates their own repo announcement (same d-tag)
        let maintainer_repo_event = match client
            .event_builder(
                Kind::GitRepoAnnouncement,
                format!("Maintainer's view of {} repository", test_name),
            )
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("name"),
                vec![format!("{} Test Repository (Maintainer)", test_name)],
            ))
            .tag(Tag::custom(
                TagKind::custom("clone"),
                vec![format!("{}/{}/{}.git", http_url, maintainer_npub, repo_id)],
            ))
            .tag(Tag::custom(
                TagKind::custom("relays"),
                vec![relay_url.clone()],
            ))
            .build(&maintainer_keys)
        {
            Ok(e) => e,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to build maintainer repo event: {}", e))
            }
        };

        if let Err(e) = client.client().send_event(&maintainer_repo_event).await {
            return TestResult::new(test_name, "GRASP-01", description)
                .fail(&format!("Failed to send maintainer repo event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // Verify maintainer's repo was created
        let maintainer_repo_path = git_data_dir
            .join(&maintainer_npub)
            .join(format!("{}.git", repo_id));
        if !maintainer_repo_path.exists() {
            return TestResult::new(test_name, "GRASP-01", description).fail(&format!(
                "Maintainer repo not created at: {}",
                maintainer_repo_path.display()
            ));
        }

        // 4. Clone maintainer's repo
        let clone_path = match clone_repo(relay_domain, &maintainer_npub, &repo_id) {
            Ok(p) => p,
            Err(e) => {
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to clone maintainer repo: {}", e))
            }
        };

        // 5. Create first commit (commit_a) - MAINTAINER will announce this with OLDER timestamp
        let commit_a = match create_commit(&clone_path, "Commit A - older state (maintainer)") {
            Ok(h) => h,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to create commit_a: {}", e));
            }
        };

        // 6. Create second commit (commit_b) - OWNER will announce this with NEWER timestamp
        let commit_b = match create_commit(&clone_path, "Commit B - newer state (owner)") {
            Ok(h) => h,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to create commit_b: {}", e));
            }
        };

        // 7. Calculate timestamps: older_timestamp (100 seconds ago) and newer_timestamp (now)
        let base_time = Timestamp::now().as_u64();
        let older_timestamp = Timestamp::from(base_time - 100); // 100 seconds ago - for MAINTAINER
        let newer_timestamp = Timestamp::from(base_time);        // now - for OWNER

        // 8. MAINTAINER publishes state event for commit_a at OLDER timestamp
        // This is the KEY DIFFERENCE from test_latest_state_event_used:
        // - In Task 8: Owner was older, Maintainer was newer
        // - In Task 9 (this test): Maintainer is older, Owner is newer
        let maintainer_state_event = match client
            .event_builder(Kind::Custom(30618), "")
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("refs/heads/main"),
                vec![commit_a.clone()],
            ))
            .custom_time(older_timestamp)
            .build(&maintainer_keys)
        {
            Ok(e) => e,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to build maintainer state event: {}", e));
            }
        };

        if let Err(e) = client.client().send_event(&maintainer_state_event).await {
            let _ = fs::remove_dir_all(&clone_path);
            return TestResult::new(test_name, "GRASP-01", description)
                .fail(&format!("Failed to send maintainer state event: {}", e));
        }

        // 9. OWNER publishes state event for commit_b at NEWER timestamp
        let owner_state_event = match client
            .event_builder(Kind::Custom(30618), "")
            .tag(Tag::identifier(&repo_id))
            .tag(Tag::custom(
                TagKind::custom("refs/heads/main"),
                vec![commit_b.clone()],
            ))
            .custom_time(newer_timestamp)
            .build(client.keys())
        {
            Ok(e) => e,
            Err(e) => {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description)
                    .fail(&format!("Failed to build owner state event: {}", e));
            }
        };

        if let Err(e) = client.client().send_event(&owner_state_event).await {
            let _ = fs::remove_dir_all(&clone_path);
            return TestResult::new(test_name, "GRASP-01", description)
                .fail(&format!("Failed to send owner state event: {}", e));
        }

        tokio::time::sleep(std::time::Duration::from_millis(200)).await;

        // 10. Create and checkout main branch pointing to commit_b (the newer state)
        let branch_output = Command::new("git")
            .args(["branch", "main"])
            .current_dir(&clone_path)
            .output();

        if let Ok(output) = branch_output {
            if !output.status.success() {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description).fail(&format!(
                    "Failed to create main branch: {}",
                    String::from_utf8_lossy(&output.stderr)
                ));
            }
        }

        let checkout_output = Command::new("git")
            .args(["checkout", "main"])
            .current_dir(&clone_path)
            .output();

        if let Ok(output) = checkout_output {
            if !output.status.success() {
                let _ = fs::remove_dir_all(&clone_path);
                return TestResult::new(test_name, "GRASP-01", description).fail(&format!(
                    "Failed to checkout main branch: {}",
                    String::from_utf8_lossy(&output.stderr)
                ));
            }
        }

        // 11. Attempt push - should be ACCEPTED because owner's newer state event
        // announces commit_b which is now HEAD of main
        let push_result = try_push(&clone_path);
        let _ = fs::remove_dir_all(&clone_path);

        match push_result {
            Ok(true) => TestResult::new(test_name, "GRASP-01", description).pass(),
            Ok(false) => TestResult::new(test_name, "GRASP-01", description).fail(&format!(
                "Push was rejected but should have been accepted. \
                The OWNER published a state event at timestamp {} announcing commit_b ({}). \
                The MAINTAINER published an older state event at timestamp {} announcing commit_a ({}). \
                The relay should use the NEWER state event (owner's) for authorization. \
                This confirms symmetry with test_latest_state_event_used: timestamp is the deciding factor.",
                newer_timestamp.as_u64(),
                commit_b,
                older_timestamp.as_u64(),
                commit_a
            )),
            Err(e) => {
                TestResult::new(test_name, "GRASP-01", description).fail(&format!("Push error: {}", e))
            }
        }
    }
}

#[cfg(test)]
mod tests {
    #[test]
    fn test_module_exists() {
        assert!(true);
    }
}