1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
|
/// Nostr Relay Builder Configuration
///
/// This module integrates nostr-relay-builder with NIP-34 validation logic
/// preserved from the original implementation.
use std::net::SocketAddr;
use std::path::{Path, PathBuf};
use std::sync::Arc;
use nostr::nips::nip19::ToBech32;
use nostr::prelude::{Alphabet, SingleLetterTag};
use nostr::{EventId, Filter, Kind, PublicKey};
use nostr_relay_builder::prelude::*;
use crate::config::{Config, DatabaseBackend};
use crate::git;
use crate::nostr::events::{
validate_announcement, validate_state, RepositoryAnnouncement, RepositoryState, KIND_PR,
KIND_PR_UPDATE, KIND_REPOSITORY_ANNOUNCEMENT, KIND_REPOSITORY_STATE,
};
/// Result of aligning a repository with authorized state
#[derive(Debug, Default)]
struct AlignmentResult {
/// Number of refs created
refs_created: usize,
/// Number of refs updated
refs_updated: usize,
/// Number of refs deleted
refs_deleted: usize,
/// Whether HEAD was set
head_set: bool,
}
/// NIP-34 Write Policy with Full GRASP-01 Event Validation
///
/// Validates all events according to GRASP-01 specification:
/// - Repository announcements must list service in clone and relays tags
/// - Repository state announcements must have valid structure
/// - Other events must reference accepted repositories or events
/// - Forward references are supported (events referenced by accepted events)
/// - Orphan events with no valid references are rejected
///
/// Uses stateful database queries to check event relationships.
#[derive(Debug, Clone)]
pub struct Nip34WritePolicy {
domain: String,
database: Arc<MemoryDatabase>,
git_data_path: PathBuf,
}
impl Nip34WritePolicy {
pub fn new(
domain: impl Into<String>,
database: Arc<MemoryDatabase>,
git_data_path: impl Into<PathBuf>,
) -> Self {
Self {
domain: domain.into(),
database,
git_data_path: git_data_path.into(),
}
}
/// Create a bare git repository if it doesn't exist
/// Path format: <git_data_path>/<npub>/<identifier>.git
fn ensure_bare_repository(&self, announcement: &RepositoryAnnouncement) -> Result<(), String> {
let repo_path = self.git_data_path.join(announcement.repo_path());
// Check if repository already exists
if repo_path.exists() {
tracing::debug!("Repository already exists at {}", repo_path.display());
return Ok(());
}
// Create parent directory (npub directory)
let parent = repo_path
.parent()
.ok_or_else(|| format!("Invalid repository path: {}", repo_path.display()))?;
std::fs::create_dir_all(parent)
.map_err(|e| format!("Failed to create directory {}: {}", parent.display(), e))?;
// Initialize bare repository using git command
let output = std::process::Command::new("git")
.args(["init", "--bare", repo_path.to_str().unwrap()])
.output()
.map_err(|e| format!("Failed to execute git init: {}", e))?;
if !output.status.success() {
let stderr = String::from_utf8_lossy(&output.stderr);
return Err(format!("git init failed: {}", stderr));
}
tracing::info!("Created bare repository at {}", repo_path.display());
Ok(())
}
/// Check if this state event is the latest for its identifier among authorized authors
///
/// A state is considered "latest" if no other state event in the database
/// from an authorized author has a newer timestamp. This handles out-of-order
/// delivery where an older event arrives after a newer one.
///
/// The authorized_pubkeys should be the owner and maintainers of a specific
/// announcement, so different owners with the same identifier don't interfere.
async fn is_latest_state_for_identifier(
database: &Arc<MemoryDatabase>,
state: &RepositoryState,
authorized_pubkeys: &[PublicKey],
) -> Result<bool, String> {
let filter = Filter::new()
.kind(Kind::from(KIND_REPOSITORY_STATE))
.custom_tag(
SingleLetterTag::lowercase(Alphabet::D),
state.identifier.clone(),
);
match database.query(filter).await {
Ok(events) => {
for event in events {
// Skip comparing to self (same event ID)
if event.id == state.event.id {
continue;
}
// Only consider events from authorized authors for this announcement
if !authorized_pubkeys.contains(&event.pubkey) {
continue;
}
// If any existing event from an authorized author is newer, this is not the latest
if event.created_at > state.event.created_at {
tracing::debug!(
"State {} is not latest: found newer state {} from {} (ts {} > {})",
state.event.id.to_hex(),
event.id.to_hex(),
event.pubkey.to_hex(),
event.created_at.as_secs(),
state.event.created_at.as_secs()
);
return Ok(false);
}
}
Ok(true)
}
Err(e) => Err(format!("Database query failed: {}", e)),
}
}
/// Find all repository announcements where the given pubkey is authorized
///
/// A pubkey is authorized for an announcement if:
/// - They are the owner (pubkey of the announcement event), OR
/// - They are listed in the "maintainers" tag
///
/// This is needed because a maintainer can publish a state event that
/// should update HEAD in the repository of the announcement owner,
/// not in the maintainer's own (possibly non-existent) repository.
async fn find_authorized_announcements(
database: &Arc<MemoryDatabase>,
identifier: &str,
state_author: &PublicKey,
) -> Result<Vec<RepositoryAnnouncement>, String> {
let filter = Filter::new()
.kind(Kind::from(KIND_REPOSITORY_ANNOUNCEMENT))
.custom_tag(
SingleLetterTag::lowercase(Alphabet::D),
identifier.to_string(),
);
match database.query(filter).await {
Ok(events) => {
let mut authorized = Vec::new();
let state_author_hex = state_author.to_hex();
for event in events {
if let Ok(announcement) = RepositoryAnnouncement::from_event(event.clone()) {
// Check if state author is authorized for this announcement
let is_owner = event.pubkey == *state_author;
let is_maintainer = announcement.maintainers.contains(&state_author_hex);
if is_owner || is_maintainer {
tracing::debug!(
"Found authorized announcement for {}: owner={}, maintainer={}",
identifier,
if is_owner {
event.pubkey.to_hex()
} else {
"n/a".to_string()
},
is_maintainer
);
authorized.push(announcement);
}
}
}
Ok(authorized)
}
Err(e) => Err(format!("Database query failed: {}", e)),
}
}
/// Identify all owner repositories for which this state event is the latest authorized state
///
/// Returns a list of (announcement, repo_path) pairs where:
/// - The state author is authorized (owner or maintainer)
/// - This state event is the latest for the identifier in that context
async fn identify_owner_repositories(
&self,
database: &Arc<MemoryDatabase>,
state: &RepositoryState,
) -> Result<Vec<(RepositoryAnnouncement, std::path::PathBuf)>, String> {
// Find all announcements where state author is authorized
let announcements =
Self::find_authorized_announcements(database, &state.identifier, &state.event.pubkey)
.await?;
if announcements.is_empty() {
tracing::debug!(
"No authorized announcements found for state {} by {}",
state.identifier,
state.event.pubkey.to_hex()
);
return Ok(Vec::new());
}
let mut owner_repos = Vec::new();
for announcement in announcements {
// Build the list of authorized pubkeys for this specific announcement
// (owner + maintainers)
let mut authorized_pubkeys = vec![announcement.event.pubkey];
for maintainer_hex in &announcement.maintainers {
if let Ok(pk) = PublicKey::from_hex(maintainer_hex) {
authorized_pubkeys.push(pk);
}
}
// Check if this is the latest state event for THIS announcement's context
if !Self::is_latest_state_for_identifier(database, state, &authorized_pubkeys).await? {
tracing::debug!(
"Skipping {} in {}'s repo - not the latest state event for this context",
state.identifier,
announcement.event.pubkey.to_hex()
);
continue;
}
// Build repository path: <git_data_path>/<owner_npub>/<identifier>.git
let repo_path = self.git_data_path.join(announcement.repo_path().clone());
owner_repos.push((announcement, repo_path));
}
Ok(owner_repos)
}
/// Align an owner repository's refs with the authorized state
///
/// This function:
/// 1. Deletes refs that are in the repo but not in the state (for refs/heads/ and refs/tags/)
/// 2. Updates refs that exist in state if we have the commit (for refs/heads/ and refs/tags/)
/// 3. Sets HEAD if the HEAD branch's commit is available
///
/// Per GRASP-01: "MUST set repository HEAD per repository state announcement
/// as soon as the git data related to that branch has been received."
///
/// Returns a summary of actions taken.
fn align_owner_repository_with_state(
&self,
repo_path: &std::path::Path,
state: &RepositoryState,
) -> AlignmentResult {
let mut result = AlignmentResult::default();
// Check if repository exists
if !repo_path.exists() {
tracing::debug!(
"Repository not found at {}, cannot align with state",
repo_path.display()
);
return result;
}
// Get current refs from the repository
let current_refs = match git::list_refs(repo_path) {
Ok(refs) => refs,
Err(e) => {
tracing::warn!("Failed to list refs in {}: {}", repo_path.display(), e);
return result;
}
};
// Build expected refs from state
let mut expected_refs: std::collections::HashMap<String, String> =
std::collections::HashMap::new();
for branch in &state.branches {
let ref_name = format!("refs/heads/{}", branch.name);
expected_refs.insert(ref_name, branch.commit.clone());
}
for tag in &state.tags {
let ref_name = format!("refs/tags/{}", tag.name);
expected_refs.insert(ref_name, tag.commit.clone());
}
// Process current refs: update or delete as needed
for (ref_name, current_commit) in ¤t_refs {
// Only process refs/heads/ and refs/tags/
if !ref_name.starts_with("refs/heads/") && !ref_name.starts_with("refs/tags/") {
continue;
}
match expected_refs.get(ref_name) {
Some(expected_commit) => {
// Ref should exist - check if commit matches
if current_commit != expected_commit {
// Check if we have the expected commit
if git::commit_exists(repo_path, expected_commit) {
// Update the ref
match git::update_ref(repo_path, ref_name, expected_commit) {
Ok(()) => {
tracing::info!(
"Updated {} from {} to {} in {}",
ref_name,
current_commit,
expected_commit,
repo_path.display()
);
result.refs_updated += 1;
}
Err(e) => {
tracing::warn!(
"Failed to update {} in {}: {}",
ref_name,
repo_path.display(),
e
);
}
}
} else {
tracing::debug!(
"Commit {} not available for {} in {}",
expected_commit,
ref_name,
repo_path.display()
);
}
}
}
None => {
// Ref should not exist - delete it
match git::delete_ref(repo_path, ref_name) {
Ok(()) => {
tracing::info!(
"Deleted {} (not in state) from {}",
ref_name,
repo_path.display()
);
result.refs_deleted += 1;
}
Err(e) => {
tracing::warn!(
"Failed to delete {} from {}: {}",
ref_name,
repo_path.display(),
e
);
}
}
}
}
}
// Add refs that exist in state but not in repo (if we have the commit)
for (ref_name, expected_commit) in &expected_refs {
let exists = current_refs.iter().any(|(r, _)| r == ref_name);
if !exists && git::commit_exists(repo_path, expected_commit) {
match git::update_ref(repo_path, ref_name, expected_commit) {
Ok(()) => {
tracing::info!(
"Created {} at {} in {}",
ref_name,
expected_commit,
repo_path.display()
);
result.refs_created += 1;
}
Err(e) => {
tracing::warn!(
"Failed to create {} in {}: {}",
ref_name,
repo_path.display(),
e
);
}
}
}
}
// Set HEAD if specified in state
if let Some(head_ref) = &state.head {
if let Some(branch_name) = state.get_head_branch() {
if let Some(head_commit) = state.get_branch_commit(branch_name) {
match git::try_set_head_if_available(repo_path, head_ref, head_commit) {
Ok(true) => {
tracing::info!(
"Set HEAD to {} in {} (from state by {})",
head_ref,
repo_path.display(),
state.event.pubkey.to_hex()
);
result.head_set = true;
}
Ok(false) => {
tracing::debug!(
"HEAD commit {} not available yet in {}",
head_commit,
repo_path.display()
);
}
Err(e) => {
tracing::warn!("Failed to set HEAD in {}: {}", repo_path.display(), e);
}
}
}
}
}
result
}
/// Extract all reference tags from an event (a, A, q, e, E)
/// Returns (addressable_refs, event_refs)
fn extract_reference_tags(event: &Event) -> (Vec<String>, Vec<EventId>) {
let mut addressable_refs = Vec::new();
let mut event_refs = Vec::new();
for tag in event.tags.iter() {
let tag_vec = tag.clone().to_vec();
if tag_vec.is_empty() {
continue;
}
match tag_vec[0].as_str() {
// Addressable event references (a, A, q with kind:pubkey:identifier format)
"a" | "A" | "q" if tag_vec.len() > 1 && tag_vec[1].contains(':') => {
addressable_refs.push(tag_vec[1].clone());
}
// Event ID references (e, E, q with event ID format)
"e" | "E" if tag_vec.len() > 1 => {
if let Ok(event_id) = EventId::from_hex(&tag_vec[1]) {
event_refs.push(event_id);
}
}
"q" if tag_vec.len() > 1 && !tag_vec[1].contains(':') => {
if let Ok(event_id) = EventId::from_hex(&tag_vec[1]) {
event_refs.push(event_id);
}
}
_ => {}
}
}
(addressable_refs, event_refs)
}
/// Validate refs/nostr/<event-id> ref against a PR or PR Update event's `c` tag
///
/// When a PR event (kind 1618) or PR Update event (kind 1619) is received,
/// this checks if a corresponding refs/nostr/<event-id> ref exists in the
/// repository and validates that it points to the correct commit (from the
/// `c` tag). If the ref exists but points to a different commit, the ref is
/// deleted.
///
/// PR and PR Update events can have multiple `a` tags to update multiple
/// repositories simultaneously.
///
/// This is part of GRASP-01 compliance: ensuring refs/nostr refs are consistent
/// with their corresponding events.
///
/// # Arguments
/// * `database` - Database for looking up repository announcements
/// * `event` - The PR event (kind 1618) or PR Update event (kind 1619)
///
/// # Returns
/// Ok(Some(n)) if n refs were deleted, Ok(None) if no action taken, Err on failure
async fn validate_pr_nostr_ref(
&self,
database: &Arc<MemoryDatabase>,
event: &Event,
) -> Result<Option<usize>, String> {
let event_id = event.id.to_hex();
// Extract the `c` tag (commit hash) from the PR event
let expected_commit = event.tags.iter().find_map(|tag| {
let tag_vec = tag.clone().to_vec();
if tag_vec.len() >= 2 && tag_vec[0] == "c" {
Some(tag_vec[1].clone())
} else {
None
}
});
let expected_commit = match expected_commit {
Some(c) => c,
None => {
tracing::debug!(
"PR event {} has no 'c' tag, skipping ref validation",
event_id
);
return Ok(None);
}
};
// Extract ALL `a` tags (repository references) from the PR event
// PR events can reference multiple repositories
// Format: 30617:<pubkey>:<identifier>
let repo_refs: Vec<String> = event
.tags
.iter()
.filter_map(|tag| {
let tag_vec = tag.clone().to_vec();
if tag_vec.len() >= 2 && tag_vec[0] == "a" && tag_vec[1].starts_with("30617:") {
Some(tag_vec[1].clone())
} else {
None
}
})
.collect();
if repo_refs.is_empty() {
tracing::debug!(
"PR event {} has no repo 'a' tags, skipping ref validation",
event_id
);
return Ok(None);
}
let mut deleted_count = 0;
// Process each repository reference
for repo_ref in repo_refs {
// Parse the repo reference: 30617:<pubkey>:<identifier>
let parts: Vec<&str> = repo_ref.split(':').collect();
if parts.len() < 3 {
tracing::debug!(
"PR event {} has invalid 'a' tag format: {}",
event_id,
repo_ref
);
continue;
}
let repo_pubkey = match PublicKey::from_hex(parts[1]) {
Ok(pk) => pk,
Err(_) => {
tracing::debug!(
"PR event {} has invalid pubkey in 'a' tag: {}",
event_id,
parts[1]
);
continue;
}
};
let identifier = parts[2];
// Look up repository announcement to get the npub for path
let filter = Filter::new()
.kind(Kind::from(KIND_REPOSITORY_ANNOUNCEMENT))
.author(repo_pubkey)
.custom_tag(
SingleLetterTag::lowercase(Alphabet::D),
identifier.to_string(),
);
let announcements: Vec<Event> = match database.query(filter).await {
Ok(events) => events.into_iter().collect(),
Err(e) => {
tracing::warn!(
"Failed to query for repository announcement for PR {}: {}",
event_id,
e
);
continue;
}
};
if announcements.is_empty() {
tracing::debug!(
"No repository announcement found for PR event {} (repo {}:{})",
event_id,
repo_pubkey.to_hex(),
identifier
);
continue;
}
// Process each matching announcement (there could be multiple)
for announcement_event in announcements {
let announcement = match RepositoryAnnouncement::from_event(announcement_event) {
Ok(a) => a,
Err(e) => {
tracing::warn!(
"Failed to parse announcement for PR {} validation: {}",
event_id,
e
);
continue;
}
};
// Build repository path
let repo_path = self.git_data_path.join(announcement.repo_path());
// Validate the ref
match git::validate_nostr_ref(&repo_path, &event_id, &expected_commit) {
Ok(true) => {
tracing::info!(
"Deleted mismatched refs/nostr/{} in {} (expected commit {})",
event_id,
repo_path.display(),
expected_commit
);
deleted_count += 1;
}
Ok(false) => {
tracing::debug!(
"refs/nostr/{} in {} is valid or doesn't exist",
event_id,
repo_path.display()
);
}
Err(e) => {
tracing::warn!(
"Failed to validate refs/nostr/{} in {}: {}",
event_id,
repo_path.display(),
e
);
}
}
}
}
if deleted_count > 0 {
Ok(Some(deleted_count))
} else {
Ok(None)
}
}
/// Check if any addressable events (repositories) exist in database
/// Returns the first matching addressable reference found, or None if none match
async fn find_accepted_repository(
database: &Arc<MemoryDatabase>,
addressables: &[String],
) -> Result<Option<String>, String> {
if addressables.is_empty() {
return Ok(None);
}
// Parse all addressable references
let mut parsed_refs = Vec::new();
for addr in addressables {
let parts: Vec<&str> = addr.split(':').collect();
if parts.len() < 3 {
continue; // Skip invalid format
}
let kind = match parts[0].parse::<u16>() {
Ok(k) => k,
Err(_) => continue, // Skip invalid kind
};
let pubkey = match PublicKey::from_hex(parts[1]) {
Ok(pk) => pk,
Err(_) => continue, // Skip invalid pubkey
};
let identifier = parts[2].to_string();
parsed_refs.push((addr.clone(), kind, pubkey, identifier));
}
if parsed_refs.is_empty() {
return Ok(None);
}
// Group by kind to reduce queries
use std::collections::HashMap;
let mut by_kind: HashMap<u16, Vec<_>> = HashMap::new();
for (addr, kind, pubkey, identifier) in parsed_refs {
by_kind
.entry(kind)
.or_default()
.push((addr, pubkey, identifier));
}
// Query each kind group
for (kind, refs) in by_kind {
let authors: Vec<PublicKey> = refs.iter().map(|(_, pk, _)| *pk).collect();
let filter = Filter::new().kind(Kind::from(kind)).authors(authors);
match database.query(filter).await {
Ok(events) => {
// Check if any event matches our identifier requirements
for event in events {
for (addr, _pubkey, identifier) in &refs {
// Match identifier tag
if event.tags.iter().any(|tag| {
let tag_vec = tag.clone().to_vec();
tag_vec.len() >= 2 && tag_vec[0] == "d" && tag_vec[1] == *identifier
}) {
return Ok(Some(addr.clone()));
}
}
}
}
Err(e) => return Err(format!("Database query failed: {}", e)),
}
}
Ok(None)
}
/// Check if any events exist in database
/// Returns the first matching event ID found, or None if none match
async fn find_accepted_event(
database: &Arc<MemoryDatabase>,
event_ids: &[EventId],
) -> Result<Option<EventId>, String> {
if event_ids.is_empty() {
return Ok(None);
}
// Single query for all event IDs
let filter = Filter::new().ids(event_ids.iter().copied());
match database.query(filter).await {
Ok(events) => {
// Get first event from the iterator
Ok(events.into_iter().next().map(|e| e.id))
}
Err(e) => Err(format!("Database query failed: {}", e)),
}
}
/// Check if any accepted event references this event (forward reference)
///
/// For regular replaceable events (10000-19999): Checks addressable tags with kind:pubkey format
/// For parameterized replaceable (30000-39999): Checks addressable tags with kind:pubkey:d-identifier format
/// For regular events: Only checks event ID reference tags (e, E, q)
///
/// This optimization recognizes that replaceable events are referenced by coordinate address,
/// while regular events are referenced by event ID.
async fn is_referenced_by_accepted(
database: &Arc<MemoryDatabase>,
event: &Event,
) -> Result<bool, String> {
let kind_u16 = event.kind.as_u16();
// Check if this is any kind of replaceable event
let is_regular_replaceable = (10000..20000).contains(&kind_u16);
let is_parameterized_replaceable = (30000..40000).contains(&kind_u16);
if is_regular_replaceable || is_parameterized_replaceable {
// Build the appropriate address format based on event type
let address = if is_parameterized_replaceable {
// For parameterized replaceable: kind:pubkey:d-identifier format (2 colons)
let identifier = event
.tags
.iter()
.find_map(|tag| {
let tag_vec = tag.clone().to_vec();
if tag_vec.len() >= 2 && tag_vec[0] == "d" {
Some(tag_vec[1].clone())
} else {
None
}
})
.unwrap_or_default(); // Empty string if no 'd' tag
format!(
"{}:{}:{}",
event.kind.as_u16(),
event.pubkey.to_hex(),
identifier
)
} else {
// For regular replaceable: kind:pubkey format (1 colon)
format!("{}:{}", event.kind.as_u16(), event.pubkey.to_hex())
};
// Check addressable reference tags: a, A, q (with address format)
let addressable_tags = [
SingleLetterTag::lowercase(Alphabet::A), // 'a' - addressable event reference
SingleLetterTag::uppercase(Alphabet::A), // 'A' - uppercase addressable reference
SingleLetterTag::lowercase(Alphabet::Q), // 'q' - quote (can be address or ID)
];
for tag_type in &addressable_tags {
let filter = Filter::new().custom_tag(*tag_type, address.clone());
match database.query(filter).await {
Ok(events) => {
if !events.is_empty() {
return Ok(true);
}
}
Err(e) => return Err(format!("Database query failed: {}", e)),
}
}
} else {
// For regular events, check event ID reference tags: e, E, q (with hex ID)
let event_id_hex = event.id.to_hex();
let event_id_tags = [
SingleLetterTag::lowercase(Alphabet::E), // 'e' - standard event reference
SingleLetterTag::uppercase(Alphabet::E), // 'E' - NIP-22 root event reference
SingleLetterTag::lowercase(Alphabet::Q), // 'q' - quote reference
];
for tag_type in &event_id_tags {
let filter = Filter::new().custom_tag(*tag_type, event_id_hex.clone());
match database.query(filter).await {
Ok(events) => {
if !events.is_empty() {
return Ok(true);
}
}
Err(e) => return Err(format!("Database query failed: {}", e)),
}
}
}
Ok(false)
}
}
impl WritePolicy for Nip34WritePolicy {
fn admit_event<'a>(
&'a self,
event: &'a nostr_relay_builder::prelude::Event,
_addr: &'a SocketAddr,
) -> BoxedFuture<'a, PolicyResult> {
let database = self.database.clone();
let domain = self.domain.clone();
Box::pin(async move {
let event_id_str = event.id.to_bech32().unwrap_or_else(|_| event.id.to_hex());
match event.kind.as_u16() {
KIND_REPOSITORY_ANNOUNCEMENT => match validate_announcement(event, &domain) {
Ok(_) => {
// Parse announcement to get repository details
match RepositoryAnnouncement::from_event(event.clone()) {
Ok(announcement) => {
// Try to create bare repository if it doesn't exist
if let Err(e) = self.ensure_bare_repository(&announcement) {
tracing::warn!(
"Failed to create bare repository for {}: {}",
event_id_str,
e
);
// Note: We still accept the event even if repo creation fails
// The git operation failure shouldn't prevent event acceptance
}
tracing::debug!(
"Accepted repository announcement: {}",
event_id_str
);
PolicyResult::Accept
}
Err(e) => {
tracing::warn!(
"Failed to parse repository announcement {}: {}",
event_id_str,
e
);
PolicyResult::Reject(format!("Failed to parse announcement: {}", e))
}
}
}
Err(e) => {
tracing::warn!("Rejected repository announcement {}: {}", event_id_str, e);
PolicyResult::Reject(e.to_string())
}
},
KIND_REPOSITORY_STATE => match validate_state(event) {
Ok(_) => {
// Parse state to get HEAD and branch info
match RepositoryState::from_event(event.clone()) {
Ok(state) => {
// Identify owner repositories for which this is the latest authorized state
match self.identify_owner_repositories(&database, &state).await {
Ok(owner_repos) => {
let repo_count = owner_repos.len();
let mut total_aligned = 0;
// Align each owner repository with the authorized state
for (_announcement, repo_path) in owner_repos {
let result = self.align_owner_repository_with_state(
&repo_path, &state,
);
if result.refs_created > 0
|| result.refs_updated > 0
|| result.refs_deleted > 0
|| result.head_set
{
tracing::info!(
"Aligned {} with state {}: created={}, updated={}, deleted={}, head_set={}",
repo_path.display(),
event_id_str,
result.refs_created,
result.refs_updated,
result.refs_deleted,
result.head_set
);
total_aligned += 1;
}
}
if repo_count > 0 {
tracing::info!(
"Processed state event {} for {} repo(s) ({} aligned) with identifier {}",
event_id_str,
repo_count,
total_aligned,
state.identifier
);
} else {
tracing::debug!(
"No owner repos to align for state {} - git data not available yet or not latest",
event_id_str
);
}
}
Err(e) => {
tracing::warn!(
"Failed to identify owner repositories for state {}: {}",
event_id_str,
e
);
}
}
tracing::debug!("Accepted repository state: {}", event_id_str);
PolicyResult::Accept
}
Err(e) => {
tracing::warn!(
"Failed to parse repository state {}: {}",
event_id_str,
e
);
// Still accept the event even if we can't parse it
// The validation passed, so it's structurally valid
PolicyResult::Accept
}
}
}
Err(e) => {
tracing::warn!("Rejected repository state {}: {}", event_id_str, e);
PolicyResult::Reject(e.to_string())
}
},
// KIND_PR (1618) and KIND_PR_UPDATE (1619): Validate refs/nostr/<event-id> refs before acceptance
KIND_PR | KIND_PR_UPDATE => {
// Validate refs/nostr refs for this PR event
// This deletes any refs/nostr/<event-id> that points to wrong commit
if let Err(e) = self.validate_pr_nostr_ref(&database, event).await {
tracing::warn!(
"Failed to validate refs/nostr for PR event {}: {}",
event_id_str,
e
);
// Don't reject - just log the error and proceed with normal validation
}
// Continue with standard reference checking (same as default case)
let (addressable_refs, event_refs) = Self::extract_reference_tags(event);
// Check 1: Does this event reference an accepted repository?
match Self::find_accepted_repository(&database, &addressable_refs).await {
Ok(Some(addr_ref)) => {
tracing::debug!(
"Accepted PR event {}: references accepted repository {}",
event_id_str,
addr_ref
);
return PolicyResult::Accept;
}
Ok(None) => {
// No matching repositories, continue to next check
}
Err(e) => {
tracing::warn!(
"Database query failed for PR {}, rejecting (fail-secure): {}",
event_id_str,
e
);
return PolicyResult::Reject(format!("Database query failed: {}", e));
}
}
// Check 2: Does this event reference an accepted event?
match Self::find_accepted_event(&database, &event_refs).await {
Ok(Some(event_ref)) => {
tracing::debug!(
"Accepted PR event {}: references accepted event {}",
event_id_str,
event_ref
);
return PolicyResult::Accept;
}
Ok(None) => {
// No matching events, continue to next check
}
Err(e) => {
tracing::warn!(
"Database query failed for PR {}, rejecting (fail-secure): {}",
event_id_str,
e
);
return PolicyResult::Reject(format!("Database query failed: {}", e));
}
}
// Check 3: Is this event referenced by an accepted event?
match Self::is_referenced_by_accepted(&database, event).await {
Ok(true) => {
tracing::debug!(
"Accepted PR event {}: referenced by accepted event",
event_id_str
);
return PolicyResult::Accept;
}
Ok(false) => {
// No forward references found, continue to rejection
}
Err(e) => {
tracing::warn!(
"Database query failed for PR {}, rejecting (fail-secure): {}",
event_id_str,
e
);
return PolicyResult::Reject(format!("Database query failed: {}", e));
}
}
// No valid references found - reject as orphan event
tracing::info!(
"Rejected orphan PR event {}: no references to accepted repos or events",
event_id_str
);
PolicyResult::Reject(
"PR event must reference an accepted repository or accepted event"
.to_string(),
)
}
// GRASP-01: Check if event references accepted repositories or events
_ => {
// Extract all reference tags from event
let (addressable_refs, event_refs) = Self::extract_reference_tags(event);
// Check 1: Does this event reference an accepted repository? (batched)
match Self::find_accepted_repository(&database, &addressable_refs).await {
Ok(Some(addr_ref)) => {
tracing::debug!(
"Accepted event {}: references accepted repository {}",
event_id_str,
addr_ref
);
return PolicyResult::Accept;
}
Ok(None) => {
// No matching repositories, continue to next check
}
Err(e) => {
tracing::warn!(
"Database query failed for event {}, rejecting (fail-secure): {}",
event_id_str,
e
);
return PolicyResult::Reject(format!("Database query failed: {}", e));
}
}
// Check 2: Does this event reference an accepted event? (batched, transitive)
match Self::find_accepted_event(&database, &event_refs).await {
Ok(Some(event_ref)) => {
tracing::debug!(
"Accepted event {}: references accepted event {}",
event_id_str,
event_ref
);
return PolicyResult::Accept;
}
Ok(None) => {
// No matching events, continue to next check
}
Err(e) => {
tracing::warn!(
"Database query failed for event {}, rejecting (fail-secure): {}",
event_id_str,
e
);
return PolicyResult::Reject(format!("Database query failed: {}", e));
}
}
// Check 3: Is this event referenced by an accepted event? (forward reference)
match Self::is_referenced_by_accepted(&database, event).await {
Ok(true) => {
tracing::debug!(
"Accepted event {}: referenced by accepted event",
event_id_str
);
return PolicyResult::Accept;
}
Ok(false) => {
// No forward references found, continue to rejection
}
Err(e) => {
tracing::warn!(
"Database query failed for event {}, rejecting (fail-secure): {}",
event_id_str,
e
);
return PolicyResult::Reject(format!("Database query failed: {}", e));
}
}
// No valid references found - reject as orphan event
tracing::info!(
"Rejected orphan event {}: no references to accepted repos or events (checked {} addressable, {} event refs)",
event_id_str,
addressable_refs.len(),
event_refs.len()
);
PolicyResult::Reject(
"Event must reference an accepted repository or accepted event".to_string(),
)
}
}
})
}
}
/// Result of creating a relay - includes both the relay and database
pub struct RelayWithDatabase {
/// The local relay instance
pub relay: LocalRelay,
/// The database Arc that can be used for direct queries
pub database: Arc<MemoryDatabase>,
}
/// Create a configured LocalRelay with full GRASP-01 validation
///
/// Returns a `RelayWithDatabase` struct containing:
/// - The `LocalRelay` for handling WebSocket connections
/// - The `Arc<MemoryDatabase>` for direct database queries (e.g., push authorization)
pub fn create_relay(config: &Config) -> Result<RelayWithDatabase> {
tracing::info!("Configuring nostr relay with GRASP-01 validation...");
// Determine database path
let db_path = Path::new(&config.relay_data_path);
// Create database based on configuration
let database = match config.database_backend {
DatabaseBackend::Memory => {
tracing::info!("Using in-memory database (no persistence)");
Arc::new(MemoryDatabase::with_opts(MemoryDatabaseOptions {
events: true,
max_events: Some(100_000),
}))
}
DatabaseBackend::NostrDb => {
tracing::info!("Using NostrDB backend at: {}", db_path.display());
// TODO: Implement NostrDB backend once nostr-relay-builder supports it
// For now, fall back to memory database
tracing::warn!("NostrDB backend not yet implemented, using in-memory database");
Arc::new(MemoryDatabase::with_opts(MemoryDatabaseOptions {
events: true,
max_events: Some(100_000),
}))
}
DatabaseBackend::Lmdb => {
tracing::info!("Using LMDB backend at: {}", db_path.display());
// TODO: Implement LMDB backend once nostr-relay-builder supports it
// For now, fall back to memory database
tracing::warn!("LMDB backend not yet implemented, using in-memory database");
Arc::new(MemoryDatabase::with_opts(MemoryDatabaseOptions {
events: true,
max_events: Some(100_000),
}))
}
};
// Build relay with GRASP-01 validation
// Clone Arc for the write policy so both relay and policy can access the database
let builder = RelayBuilder::default()
.database(database.clone())
.write_policy(Nip34WritePolicy::new(
&config.domain,
database.clone(),
&config.git_data_path,
));
tracing::info!(
"Relay configured with GRASP-01 validation for domain: {}",
config.domain
);
Ok(RelayWithDatabase {
relay: LocalRelay::new(builder),
database,
})
}
|