upleb.uk

Public git repos — served from a NIP-34 GRASP relay at git.upleb.uk

summaryrefslogtreecommitdiff
path: root/src/nostr/events.rs
blob: 1d5a50f71b234ac02af82992e408358d674660d0 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
/// NIP-34 Git Repository Event Handling
///
/// This module handles Git repository announcements (kind 30617) and
/// repository state announcements (kind 30618) according to NIP-34 and GRASP-01.
///
/// Reference:
/// - NIP-34: https://nips.nostr.com/34
/// - GRASP-01: https://gitworkshop.dev/danconwaydev.com/grasp/01.md
use anyhow::{anyhow, Result};
use nostr_sdk::{Event, Kind, TagKind, ToBech32};

// NOTE: Using rust-nostr Kind variants instead of hardcoded constants:
// - KIND_REPOSITORY_ANNOUNCEMENT -> Kind::GitRepoAnnouncement (30617)
// - KIND_REPOSITORY_STATE -> Kind::RepoState (30618)
// - KIND_PR -> Kind::GitPullRequest (1618)
// - KIND_PR_UPDATE -> Kind::GitPullRequestUpdate (1619)
// - KIND_USER_GRASP_LIST -> Kind::GitUserGraspList (10317)

/// Repository announcement details extracted from NIP-34 event
#[derive(Debug, Clone)]
pub struct RepositoryAnnouncement {
    pub event: Event,
    pub identifier: String,
    pub name: Option<String>,
    pub description: Option<String>,
    pub clone_urls: Vec<String>,
    pub relays: Vec<String>,
    pub web_urls: Vec<String>,
    pub maintainers: Vec<String>,
}

impl RepositoryAnnouncement {
    /// Parse a repository announcement from a NIP-34 kind 30617 event
    pub fn from_event(event: Event) -> Result<Self> {
        if event.kind != Kind::GitRepoAnnouncement {
            return Err(anyhow!(
                "Invalid event kind: expected {}, got {}",
                Kind::GitRepoAnnouncement,
                event.kind
            ));
        }

        // Extract identifier (required)
        let identifier = event
            .tags
            .iter()
            .find(|t| t.kind() == TagKind::d())
            .and_then(|t| t.content())
            .ok_or_else(|| anyhow!("Repository announcement missing 'd' tag (identifier)"))?
            .to_string();

        // Extract optional name
        let name = event
            .tags
            .iter()
            .find(|t| matches!(t.kind(), TagKind::Name))
            .and_then(|t| t.content())
            .map(|s| s.to_string());

        // Extract description from content
        let description = if event.content.is_empty() {
            None
        } else {
            Some(event.content.clone())
        };

        // Extract clone URLs
        let clone_urls = event
            .tags
            .iter()
            .filter(|t| matches!(t.kind(), TagKind::Clone))
            .flat_map(|t| {
                let vec = t.clone().to_vec();
                // Skip first element (tag name), rest are values
                vec.into_iter().skip(1)
            })
            .collect();

        // return error if mutliple clone tags (incorrect formatting)
        let clone_tag_count = event
            .tags
            .iter()
            .filter(|t| matches!(t.kind(), TagKind::Clone))
            .count();

        if clone_tag_count > 1 {
            return Err(anyhow::anyhow!("multiple clone tags found. correct format is single clone tag with multiple values"));
        }

        // Extract relays
        let relays = event
            .tags
            .iter()
            .filter(|t| matches!(t.kind(), TagKind::Relays))
            .flat_map(|t| {
                let vec = t.clone().to_vec();
                // Skip first element (tag name), rest are values
                vec.into_iter().skip(1)
            })
            .collect();

        // Extract web URLs
        let web_urls = event
            .tags
            .iter()
            .filter(|t| {
                if let TagKind::Custom(s) = t.kind() {
                    s.as_ref() == "web"
                } else {
                    false
                }
            })
            .flat_map(|t| {
                let vec = t.clone().to_vec();
                // Skip first element (tag name), rest are values
                vec.into_iter().skip(1)
            })
            .collect();

        // Extract maintainers from "maintainers" tag per NIP-34
        // Format: ["maintainers", "<pubkey1-hex>", "<pubkey2-hex>", ...]
        let maintainers = event
            .tags
            .iter()
            .find(|tag| tag.as_slice().first().map(|s| s.as_str()) == Some("maintainers"))
            .map(|tag| {
                tag.as_slice()[1..] // Skip the "maintainers" tag name
                    .iter()
                    .map(|s| s.to_string())
                    .collect()
            })
            .unwrap_or_default();

        Ok(RepositoryAnnouncement {
            event,
            identifier,
            name,
            description,
            clone_urls,
            relays,
            web_urls,
            maintainers,
        })
    }

    /// Normalize a URL by removing trailing slashes for consistent comparison
    ///
    /// See test_validate_announcement_with_trailing_slash_in_relay for why we need this
    fn normalize_url_for_comparison(url: &str) -> &str {
        url.trim_end_matches('/')
    }

    /// Check if this announcement lists the given domain in clone URLs
    pub fn has_clone_url(&self, domain: &str) -> bool {
        let normalized_domain = Self::normalize_url_for_comparison(domain);
        self.clone_urls.iter().any(|url| {
            let normalized_url = Self::normalize_url_for_comparison(url);
            normalized_url.contains(normalized_domain)
        })
    }

    /// Check if this announcement lists the given relay
    pub fn has_relay(&self, relay: &str) -> bool {
        let normalized_relay = Self::normalize_url_for_comparison(relay);
        self.relays.iter().any(|r| {
            let normalized_r = Self::normalize_url_for_comparison(r);
            normalized_r.contains(normalized_relay)
        })
    }

    /// Check if this announcement lists the service (both clone and relay)
    ///
    /// GRASP-01 requirement: MUST reject announcements that do not list
    /// the service in both `clone` and `relays` tags unless implementing GRASP-05.
    pub fn lists_service(&self, domain: &str) -> bool {
        self.has_clone_url(domain) && self.has_relay(domain)
    }

    /// Get the npub of the repository owner
    pub fn owner_npub(&self) -> String {
        self.event.pubkey.to_bech32().unwrap_or_default()
    }

    /// Get the repository path: <npub>/<identifier>.git
    pub fn repo_path(&self) -> String {
        format!("{}/{}.git", self.owner_npub(), self.identifier)
    }
}

/// Repository state details extracted from NIP-34 event
#[derive(Debug, Clone)]
pub struct RepositoryState {
    pub event: Event,
    pub identifier: String,
    pub branches: Vec<BranchState>,
    pub tags: Vec<TagState>,
    /// HEAD reference (e.g., "refs/heads/main") if specified
    pub head: Option<String>,
}

/// Branch state (ref with commit hash)
#[derive(Debug, Clone)]
pub struct BranchState {
    pub name: String,
    pub commit: String,
}

/// Tag state (ref with commit hash)
#[derive(Debug, Clone)]
pub struct TagState {
    pub name: String,
    pub commit: String,
}

impl RepositoryState {
    /// Parse a repository state from a NIP-34 kind 30618 event
    pub fn from_event(event: Event) -> Result<Self> {
        if event.kind != Kind::RepoState {
            return Err(anyhow!(
                "Invalid event kind: expected {}, got {}",
                Kind::RepoState,
                event.kind
            ));
        }

        // Extract identifier (required)
        let identifier = event
            .tags
            .iter()
            .find(|t| t.kind() == TagKind::d())
            .and_then(|t| t.content())
            .ok_or_else(|| anyhow!("Repository state missing 'd' tag (identifier)"))?
            .to_string();

        // Extract branches (refs/heads/*)
        // Tag format: ["refs/heads/main", "commit_hash"]
        let branches = event
            .tags
            .iter()
            .filter_map(|t| {
                if let TagKind::Custom(s) = t.kind() {
                    if s.as_ref().starts_with("refs/heads/") {
                        let parts = t.clone().to_vec();
                        if parts.len() >= 2 {
                            Some(BranchState {
                                name: s.as_ref().strip_prefix("refs/heads/").unwrap().to_string(),
                                commit: parts[1].clone(),
                            })
                        } else {
                            None
                        }
                    } else {
                        None
                    }
                } else {
                    None
                }
            })
            .collect();

        // Extract tags (refs/tags/*)
        // Tag format: ["refs/tags/v1.0", "commit_hash"]
        let tags = event
            .tags
            .iter()
            .filter_map(|t| {
                if let TagKind::Custom(s) = t.kind() {
                    if s.as_ref().starts_with("refs/tags/") {
                        let parts = t.clone().to_vec();
                        if parts.len() >= 2 {
                            Some(TagState {
                                name: s.as_ref().strip_prefix("refs/tags/").unwrap().to_string(),
                                commit: parts[1].clone(),
                            })
                        } else {
                            None
                        }
                    } else {
                        None
                    }
                } else {
                    None
                }
            })
            .collect();

        // Extract HEAD reference per NIP-34
        // Tag format: ["HEAD", "ref: refs/heads/main"] or ["HEAD", "refs/heads/main"]
        let head = event
            .tags
            .iter()
            .find(|t| {
                if let TagKind::Custom(s) = t.kind() {
                    s.as_ref() == "HEAD"
                } else {
                    false
                }
            })
            .and_then(|t| {
                let parts = t.clone().to_vec();
                if parts.len() >= 2 {
                    let head_value = &parts[1];
                    // Handle both "ref: refs/heads/main" and "refs/heads/main" formats
                    if let Some(stripped) = head_value.strip_prefix("ref: ") {
                        Some(stripped.to_string())
                    } else {
                        Some(head_value.clone())
                    }
                } else {
                    None
                }
            });

        Ok(RepositoryState {
            event,
            identifier,
            branches,
            tags,
            head,
        })
    }

    /// Get the commit hash for a branch
    pub fn get_branch_commit(&self, branch: &str) -> Option<&str> {
        self.branches
            .iter()
            .find(|b| b.name == branch)
            .map(|b| b.commit.as_str())
    }

    /// Get the commit hash for a tag
    pub fn get_tag_commit(&self, tag: &str) -> Option<&str> {
        self.tags
            .iter()
            .find(|t| t.name == tag)
            .map(|t| t.commit.as_str())
    }

    /// Get the owner npub
    pub fn owner_npub(&self) -> String {
        self.event.pubkey.to_bech32().unwrap_or_default()
    }

    /// Get the HEAD branch name (without refs/heads/ prefix)
    pub fn get_head_branch(&self) -> Option<&str> {
        self.head
            .as_ref()
            .and_then(|h| h.strip_prefix("refs/heads/"))
    }

    /// Check if the HEAD commit is available in the git repository
    /// Returns true if we have the git data for the HEAD branch
    pub fn head_commit_available(&self) -> bool {
        if let Some(head_branch) = self.get_head_branch() {
            self.get_branch_commit(head_branch).is_some()
        } else {
            false
        }
    }
}

/// Validate a repository announcement according to GRASP-01 and GRASP-05
///
/// Returns:
/// - Accept: Announcement lists our service (GRASP-01) AND matches repository whitelist (if enabled)
/// - AcceptArchive: Announcement matches archive config (GRASP-05)
/// - Reject: Validation failed
///
/// Blacklist takes precedence over all whitelists:
/// - If blacklisted, always reject with specific reason (npub/identifier/npub+identifier)
///
/// When archive_read_only is true:
/// - ONLY accept announcements matching archive whitelist/all
/// - REJECT announcements listing our service but not in whitelist (read-only sync mode)
///
/// When repository_whitelist is set:
/// - Announcements must BOTH list our service AND match the repository whitelist
///
/// Note: AcceptMaintainer is NOT returned here (requires database access)
pub fn validate_announcement(
    event: &Event,
    config: &crate::config::Config,
) -> crate::nostr::policy::AnnouncementResult {
    use crate::nostr::policy::AnnouncementResult;

    // Must be kind 30617
    if event.kind != Kind::GitRepoAnnouncement {
        return AnnouncementResult::Reject(format!(
            "Invalid kind: expected {}",
            Kind::GitRepoAnnouncement
        ));
    }

    // Must have identifier
    let has_identifier = event.tags.iter().any(|t| t.kind() == TagKind::d());
    if !has_identifier {
        return AnnouncementResult::Reject("Missing required 'd' tag (identifier)".to_string());
    }

    // Parse full announcement to validate structure
    let announcement = match RepositoryAnnouncement::from_event(event.clone()) {
        Ok(a) => a,
        Err(e) => return AnnouncementResult::Reject(format!("Invalid announcement: {}", e)),
    };

    // Get validated configs (config.validate() must be called at startup)
    let archive_config = config.archive_config();
    let repository_config = config.repository_config();
    let blacklist_config = config.blacklist_config();

    let npub = announcement.owner_npub();
    let lists_service = announcement.lists_service(&config.domain);

    // Check blacklist FIRST - it overrides everything
    if let Some(reason) = blacklist_config.check(&npub, &announcement.identifier) {
        return AnnouncementResult::Reject(reason);
    }

    // GRASP-01: Normal mode - accept if announcement lists our service AND matches repository whitelist (if enabled)
    if lists_service && !archive_config.read_only {
        // Check repository whitelist if enabled
        if repository_config.enabled() {
            if !repository_config.matches(&npub, &announcement.identifier) {
                return AnnouncementResult::Reject(format!(
                    "Announcement lists service but does not match repository whitelist. \
                     Repository {}/{} not in whitelist",
                    npub, announcement.identifier
                ));
            }
        }
        return AnnouncementResult::Accept;
    }

    // GRASP-05: Archive mode - accept if announcement matches whitelist
    if archive_config.matches(&npub, &announcement.identifier) {
        return AnnouncementResult::AcceptArchive;
    }

    // Reject with appropriate error message
    if archive_config.read_only {
        AnnouncementResult::Reject(format!(
            "Archive read-only mode: announcement must match archive whitelist. \
             Repository {}/{} not in whitelist",
            npub, announcement.identifier
        ))
    } else {
        AnnouncementResult::Reject(format!(
            "Announcement must list service in both 'clone' and 'relays' tags, or match archive whitelist. \
             Found clone URLs: {:?}, relays: {:?}",
            announcement.clone_urls, announcement.relays
        ))
    }
}

/// Validate a repository state announcement according to GRASP-01
///
/// Returns Ok(()) if valid, Err with reason if invalid.
pub fn validate_state(event: &Event) -> Result<()> {
    // Must be kind 30618
    if event.kind != Kind::RepoState {
        return Err(anyhow!("Invalid kind: expected {}", Kind::RepoState));
    }

    // Must have identifier
    let has_identifier = event.tags.iter().any(|t| t.kind() == TagKind::d());
    if !has_identifier {
        return Err(anyhow!("Missing required 'd' tag (identifier)"));
    }

    // Parse full state to validate structure
    let _state = RepositoryState::from_event(event.clone())?;

    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;
    use nostr_sdk::{EventBuilder, Keys};

    fn create_test_keys() -> Keys {
        Keys::generate()
    }

    fn create_announcement_event(
        keys: &Keys,
        identifier: &str,
        clone_urls: Vec<&str>,
        relays: Vec<&str>,
    ) -> Event {
        use nostr_sdk::Tag;

        let mut tags = vec![Tag::custom(
            nostr_sdk::TagKind::d(),
            vec![identifier.to_string()],
        )];

        // NIP-34: Single clone tag with multiple values
        if !clone_urls.is_empty() {
            tags.push(Tag::custom(
                nostr_sdk::TagKind::Clone,
                clone_urls.iter().map(|s| s.to_string()),
            ));
        }

        // NIP-34: Single relays tag with multiple values
        if !relays.is_empty() {
            tags.push(Tag::custom(
                nostr_sdk::TagKind::Relays,
                relays.iter().map(|s| s.to_string()),
            ));
        }

        EventBuilder::new(Kind::GitRepoAnnouncement, "Test repository")
            .tags(tags)
            .sign_with_keys(keys)
            .unwrap()
    }

    fn create_state_event(keys: &Keys, identifier: &str, branches: Vec<(&str, &str)>) -> Event {
        use nostr_sdk::Tag;

        let mut tags = vec![Tag::custom(
            nostr_sdk::TagKind::d(),
            vec![identifier.to_string()],
        )];

        for (branch, commit) in branches {
            tags.push(Tag::custom(
                nostr_sdk::TagKind::Custom(format!("refs/heads/{}", branch).into()),
                vec![commit.to_string()],
            ));
        }

        EventBuilder::new(Kind::RepoState, "")
            .tags(tags)
            .sign_with_keys(keys)
            .unwrap()
    }

    #[test]
    fn test_parse_announcement() {
        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        let announcement = RepositoryAnnouncement::from_event(event).unwrap();

        assert_eq!(announcement.identifier, "test-repo");
        assert_eq!(announcement.clone_urls.len(), 1);
        assert_eq!(announcement.relays.len(), 1);
        assert!(announcement.has_clone_url("gitnostr.com"));
        assert!(announcement.has_relay("gitnostr.com"));
        assert!(announcement.lists_service("gitnostr.com"));
    }

    #[test]
    fn test_parse_announcement_missing_identifier() {
        let keys = create_test_keys();
        let event = EventBuilder::new(Kind::GitRepoAnnouncement, "Test repository")
            .sign_with_keys(&keys)
            .unwrap();

        let result = RepositoryAnnouncement::from_event(event);
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("identifier"));
    }

    #[test]
    fn test_parse_state() {
        let keys = create_test_keys();
        let event = create_state_event(
            &keys,
            "test-repo",
            vec![("main", "a1b2c3d4"), ("develop", "e5f6g7h8")],
        );

        let state = RepositoryState::from_event(event).unwrap();

        assert_eq!(state.identifier, "test-repo");
        assert_eq!(state.branches.len(), 2);
        assert_eq!(state.get_branch_commit("main"), Some("a1b2c3d4"));
        assert_eq!(state.get_branch_commit("develop"), Some("e5f6g7h8"));
    }

    #[test]
    fn test_validate_announcement_success() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        let config = Config {
            domain: "gitnostr.com".to_string(),
            ..Config::for_testing()
        };
        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Accept));
    }

    #[test]
    fn test_validate_announcement_missing_clone() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec![], // No clone URLs
            vec!["wss://gitnostr.com"],
        );

        let config = Config {
            domain: "gitnostr.com".to_string(),
            ..Config::for_testing()
        };
        let result = validate_announcement(&event, &config);
        if let AnnouncementResult::Reject(reason) = result {
            assert!(reason.contains("clone"));
        } else {
            panic!("Expected Reject, got {:?}", result);
        }
    }

    #[test]
    fn test_validate_announcement_missing_relay() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec![], // No relays
        );

        let config = Config {
            domain: "gitnostr.com".to_string(),
            ..Config::for_testing()
        };
        let result = validate_announcement(&event, &config);
        if let AnnouncementResult::Reject(reason) = result {
            assert!(reason.contains("relays"));
        } else {
            panic!("Expected Reject, got {:?}", result);
        }
    }

    #[test]
    fn test_validate_announcement_wrong_domain() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://other-service.com/alice/test-repo.git"],
            vec!["wss://other-service.com"],
        );

        let config = Config {
            domain: "gitnostr.com".to_string(),
            ..Config::for_testing()
        };
        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Reject(_)));
    }

    #[test]
    fn test_validate_state_success() {
        let keys = create_test_keys();
        let event = create_state_event(&keys, "test-repo", vec![("main", "a1b2c3d4")]);

        let result = validate_state(&event);
        assert!(result.is_ok());
    }

    #[test]
    fn test_validate_state_missing_identifier() {
        let keys = create_test_keys();
        let event = EventBuilder::new(Kind::RepoState, "")
            .sign_with_keys(&keys)
            .unwrap();

        let result = validate_state(&event);
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("identifier"));
    }

    #[test]
    fn test_announcement_maintainers() {
        use nostr_sdk::Tag;

        let keys = create_test_keys();
        let maintainer_keys = create_test_keys();

        let mut tags = vec![
            Tag::custom(nostr_sdk::TagKind::d(), vec!["test-repo".to_string()]),
            Tag::custom(
                nostr_sdk::TagKind::Clone,
                vec!["https://gitnostr.com/alice/test-repo.git".to_string()],
            ),
            Tag::custom(
                nostr_sdk::TagKind::Relays,
                vec!["wss://gitnostr.com".to_string()],
            ),
        ];

        // Add maintainer using NIP-34 "maintainers" tag format
        // Format: ["maintainers", "<pubkey1-hex>", "<pubkey2-hex>", ...]
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("maintainers".into()),
            vec![maintainer_keys.public_key().to_hex()],
        ));

        let event = EventBuilder::new(Kind::GitRepoAnnouncement, "Test repository")
            .tags(tags)
            .sign_with_keys(&keys)
            .unwrap();

        let announcement = RepositoryAnnouncement::from_event(event).unwrap();
        assert_eq!(announcement.maintainers.len(), 1);
        assert_eq!(
            announcement.maintainers[0],
            maintainer_keys.public_key().to_hex()
        );
    }

    #[test]
    fn test_state_with_tags() {
        use nostr_sdk::Tag;

        let keys = create_test_keys();
        let mut tags = vec![Tag::custom(
            nostr_sdk::TagKind::d(),
            vec!["test-repo".to_string()],
        )];

        // Add branch
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("refs/heads/main".into()),
            vec!["a1b2c3d4".to_string()],
        ));

        // Add tag
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("refs/tags/v1.0.0".into()),
            vec!["e5f6g7h8".to_string()],
        ));

        let event = EventBuilder::new(Kind::RepoState, "")
            .tags(tags)
            .sign_with_keys(&keys)
            .unwrap();

        let state = RepositoryState::from_event(event).unwrap();
        assert_eq!(state.branches.len(), 1);
        assert_eq!(state.tags.len(), 1);
        assert_eq!(state.get_branch_commit("main"), Some("a1b2c3d4"));
        assert_eq!(state.get_tag_commit("v1.0.0"), Some("e5f6g7h8"));
    }

    #[test]
    fn test_state_with_head_ref_prefix() {
        use nostr_sdk::Tag;

        let keys = create_test_keys();
        let mut tags = vec![Tag::custom(
            nostr_sdk::TagKind::d(),
            vec!["test-repo".to_string()],
        )];

        // Add branch
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("refs/heads/main".into()),
            vec!["a1b2c3d4e5f6g7h8".to_string()],
        ));

        // Add HEAD with "ref: " prefix (common NIP-34 format)
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("HEAD".into()),
            vec!["ref: refs/heads/main".to_string()],
        ));

        let event = EventBuilder::new(Kind::RepoState, "")
            .tags(tags)
            .sign_with_keys(&keys)
            .unwrap();

        let state = RepositoryState::from_event(event).unwrap();
        assert_eq!(state.head, Some("refs/heads/main".to_string()));
        assert_eq!(state.get_head_branch(), Some("main"));
        assert!(state.head_commit_available());
    }

    #[test]
    fn test_state_with_head_no_prefix() {
        use nostr_sdk::Tag;

        let keys = create_test_keys();
        let mut tags = vec![Tag::custom(
            nostr_sdk::TagKind::d(),
            vec!["test-repo".to_string()],
        )];

        // Add branch
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("refs/heads/develop".into()),
            vec!["deadbeefcafe".to_string()],
        ));

        // Add HEAD without "ref: " prefix (also valid)
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("HEAD".into()),
            vec!["refs/heads/develop".to_string()],
        ));

        let event = EventBuilder::new(Kind::RepoState, "")
            .tags(tags)
            .sign_with_keys(&keys)
            .unwrap();

        let state = RepositoryState::from_event(event).unwrap();
        assert_eq!(state.head, Some("refs/heads/develop".to_string()));
        assert_eq!(state.get_head_branch(), Some("develop"));
        assert!(state.head_commit_available());
    }

    #[test]
    fn test_state_without_head() {
        use nostr_sdk::Tag;

        let keys = create_test_keys();
        let tags = vec![
            Tag::custom(nostr_sdk::TagKind::d(), vec!["test-repo".to_string()]),
            Tag::custom(
                nostr_sdk::TagKind::Custom("refs/heads/main".into()),
                vec!["a1b2c3d4".to_string()],
            ),
        ];

        let event = EventBuilder::new(Kind::RepoState, "")
            .tags(tags)
            .sign_with_keys(&keys)
            .unwrap();

        let state = RepositoryState::from_event(event).unwrap();
        assert_eq!(state.head, None);
        assert_eq!(state.get_head_branch(), None);
        assert!(!state.head_commit_available());
    }

    #[test]
    fn test_state_head_commit_not_available() {
        use nostr_sdk::Tag;

        let keys = create_test_keys();
        let mut tags = vec![Tag::custom(
            nostr_sdk::TagKind::d(),
            vec!["test-repo".to_string()],
        )];

        // Add branch for "main"
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("refs/heads/main".into()),
            vec!["a1b2c3d4".to_string()],
        ));

        // HEAD points to "develop" which doesn't exist in branches
        tags.push(Tag::custom(
            nostr_sdk::TagKind::Custom("HEAD".into()),
            vec!["refs/heads/develop".to_string()],
        ));

        let event = EventBuilder::new(Kind::RepoState, "")
            .tags(tags)
            .sign_with_keys(&keys)
            .unwrap();

        let state = RepositoryState::from_event(event).unwrap();
        assert_eq!(state.head, Some("refs/heads/develop".to_string()));
        assert_eq!(state.get_head_branch(), Some("develop"));
        // HEAD points to develop but only main branch exists in state
        assert!(!state.head_commit_available());
    }

    #[test]
    fn test_validate_announcement_with_trailing_slash_in_relay() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://git.shakespeare.diy/alice/test-repo.git"],
            vec!["wss://git.shakespeare.diy/"], // Trailing slash in relay
        );

        // Should accept despite trailing slash mismatch
        let config = Config {
            domain: "git.shakespeare.diy".to_string(),
            ..Config::for_testing()
        };
        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Accept));
    }

    #[test]
    fn test_validate_announcement_with_trailing_slash_in_clone_url() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://git.shakespeare.diy/"], // Trailing slash in clone URL
            vec!["wss://git.shakespeare.diy"],
        );

        // Should accept despite trailing slash mismatch
        let config = Config {
            domain: "git.shakespeare.diy".to_string(),
            ..Config::for_testing()
        };
        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Accept));
    }

    #[test]
    fn test_validate_announcement_with_trailing_slash_in_both() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://git.shakespeare.diy/alice/test-repo.git/"], // Trailing slash
            vec!["wss://git.shakespeare.diy/"],                       // Trailing slash
        );

        // Should accept with trailing slashes in both
        let config = Config {
            domain: "git.shakespeare.diy".to_string(),
            ..Config::for_testing()
        };
        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Accept));
    }

    #[test]
    fn test_validate_announcement_domain_with_trailing_slash() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // Should accept even when domain parameter has trailing slash
        let config = Config {
            domain: "gitnostr.com/".to_string(),
            ..Config::for_testing()
        };
        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Accept));
    }

    #[test]
    fn test_has_clone_url_with_trailing_slashes() {
        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://example.com/repo.git/"],
            vec!["wss://example.com"],
        );

        let announcement = RepositoryAnnouncement::from_event(event).unwrap();

        // Should match with or without trailing slash
        assert!(announcement.has_clone_url("example.com"));
        assert!(announcement.has_clone_url("example.com/"));
    }

    #[test]
    fn test_has_relay_with_trailing_slashes() {
        let keys = create_test_keys();
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://example.com/repo.git"],
            vec!["wss://example.com/"],
        );

        let announcement = RepositoryAnnouncement::from_event(event).unwrap();

        // Should match with or without trailing slash
        assert!(announcement.has_relay("example.com"));
        assert!(announcement.has_relay("example.com/"));
    }

    #[test]
    fn test_validate_announcement_archive_mode_npub() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let npub = keys.public_key().to_bech32().unwrap();

        // Create announcement that does NOT list our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://other-service.com/alice/test-repo.git"],
            vec!["wss://other-service.com"],
        );

        // Create config that whitelists this npub
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_whitelist: npub,
            archive_read_only: Some(false),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::AcceptArchive));
    }

    #[test]
    fn test_validate_announcement_archive_mode_identifier() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that does NOT list our service
        let event = create_announcement_event(
            &keys,
            "bitcoin-core",
            vec!["https://other-service.com/alice/bitcoin-core.git"],
            vec!["wss://other-service.com"],
        );

        // Create config that whitelists this identifier
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_whitelist: "bitcoin-core".to_string(),
            archive_read_only: Some(false),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::AcceptArchive));
    }

    #[test]
    fn test_validate_announcement_archive_mode_repository() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let npub = keys.public_key().to_bech32().unwrap();

        // Create announcement that does NOT list our service
        let event = create_announcement_event(
            &keys,
            "linux",
            vec!["https://other-service.com/alice/linux.git"],
            vec!["wss://other-service.com"],
        );

        // Create config that whitelists this specific repo
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_whitelist: format!("{}/linux", npub),
            archive_read_only: Some(false),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::AcceptArchive));
    }

    #[test]
    fn test_validate_announcement_archive_all() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that does NOT list our service
        let event = create_announcement_event(
            &keys,
            "any-repo",
            vec!["https://other-service.com/alice/any-repo.git"],
            vec!["wss://other-service.com"],
        );

        // Config with archive_all enabled
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_all: true,
            archive_read_only: Some(false),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::AcceptArchive));
    }

    #[test]
    fn test_validate_announcement_reject_not_in_whitelist() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that does NOT list our service
        let event = create_announcement_event(
            &keys,
            "other-repo",
            vec!["https://other-service.com/alice/other-repo.git"],
            vec!["wss://other-service.com"],
        );

        // Config that whitelists different identifier
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_whitelist: "bitcoin-core".to_string(),
            archive_read_only: Some(false),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Reject(_)));
    }

    #[test]
    fn test_validate_announcement_grasp01_takes_precedence() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that DOES list our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // With archive_read_only=false, GRASP-01 Accept takes precedence
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_all: true,
            archive_read_only: Some(false),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Accept));
    }

    #[test]
    fn test_archive_read_only_rejects_non_whitelisted() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that DOES list our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // With archive_read_only=true and whitelist that doesn't include this repo,
        // should reject even though it lists our service
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_whitelist: "bitcoin-core".to_string(),
            archive_read_only: Some(true),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Reject(_)));
    }

    #[test]
    fn test_archive_read_only_accepts_whitelisted() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let npub = keys.public_key().to_bech32().unwrap();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // With archive_read_only=true and whitelist that DOES include this repo,
        // should accept as AcceptArchive
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_whitelist: npub,
            archive_read_only: Some(true),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::AcceptArchive));
    }

    #[test]
    fn test_archive_read_only_with_archive_all() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "any-repo",
            vec!["https://gitnostr.com/alice/any-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // With archive_read_only=true and archive_all=true,
        // should accept as AcceptArchive
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_all: true,
            archive_read_only: Some(true),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::AcceptArchive));
    }

    #[test]
    fn test_repository_whitelist_accepts_matching() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let npub = keys.public_key().to_bech32().unwrap();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // Config with repository whitelist that includes this repo
        let config = Config {
            domain: "gitnostr.com".to_string(),
            repository_whitelist: npub,
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Accept));
    }

    #[test]
    fn test_repository_whitelist_rejects_non_matching() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // Config with repository whitelist that does NOT include this repo
        let config = Config {
            domain: "gitnostr.com".to_string(),
            repository_whitelist: "bitcoin-core".to_string(),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Reject(_)));
    }

    #[test]
    fn test_blacklist_rejects_npub() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let npub = keys.public_key().to_bech32().unwrap();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // Config with blacklist for this npub
        let config = Config {
            domain: "gitnostr.com".to_string(),
            repository_blacklist: npub.clone(),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        if let AnnouncementResult::Reject(reason) = result {
            assert!(reason.contains("owner"));
            assert!(reason.contains(&npub));
        } else {
            panic!("Expected Reject, got {:?}", result);
        }
    }

    #[test]
    fn test_blacklist_rejects_identifier() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "banned-repo",
            vec!["https://gitnostr.com/alice/banned-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // Config with blacklist for this identifier
        let config = Config {
            domain: "gitnostr.com".to_string(),
            repository_blacklist: "banned-repo".to_string(),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        if let AnnouncementResult::Reject(reason) = result {
            assert!(reason.contains("identifier"));
            assert!(reason.contains("banned-repo"));
        } else {
            panic!("Expected Reject, got {:?}", result);
        }
    }

    #[test]
    fn test_blacklist_rejects_specific_repository() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let npub = keys.public_key().to_bech32().unwrap();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "specific-repo",
            vec!["https://gitnostr.com/alice/specific-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // Config with blacklist for this specific repo
        let config = Config {
            domain: "gitnostr.com".to_string(),
            repository_blacklist: format!("{}/specific-repo", npub),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        if let AnnouncementResult::Reject(reason) = result {
            assert!(reason.contains(&npub));
            assert!(reason.contains("specific-repo"));
        } else {
            panic!("Expected Reject, got {:?}", result);
        }
    }

    #[test]
    fn test_blacklist_overrides_repository_whitelist() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let npub = keys.public_key().to_bech32().unwrap();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://gitnostr.com/alice/test-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // Config with both whitelist and blacklist - blacklist should win
        let config = Config {
            domain: "gitnostr.com".to_string(),
            repository_whitelist: npub.clone(),
            repository_blacklist: npub.clone(),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Reject(_)));
    }

    #[test]
    fn test_blacklist_overrides_archive_whitelist() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();
        let npub = keys.public_key().to_bech32().unwrap();

        // Create announcement that does NOT list our service
        let event = create_announcement_event(
            &keys,
            "test-repo",
            vec!["https://other-service.com/alice/test-repo.git"],
            vec!["wss://other-service.com"],
        );

        // Config with archive whitelist and blacklist - blacklist should win
        let config = Config {
            domain: "gitnostr.com".to_string(),
            archive_whitelist: npub.clone(),
            archive_read_only: Some(false),
            repository_blacklist: npub.clone(),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Reject(_)));
    }

    #[test]
    fn test_blacklist_allows_non_blacklisted() {
        use crate::config::Config;
        use crate::nostr::policy::AnnouncementResult;

        let keys = create_test_keys();

        // Create announcement that lists our service
        let event = create_announcement_event(
            &keys,
            "allowed-repo",
            vec!["https://gitnostr.com/alice/allowed-repo.git"],
            vec!["wss://gitnostr.com"],
        );

        // Config with blacklist for different identifier
        let config = Config {
            domain: "gitnostr.com".to_string(),
            repository_blacklist: "banned-repo".to_string(),
            ..Config::for_testing()
        };

        let result = validate_announcement(&event, &config);
        assert!(matches!(result, AnnouncementResult::Accept));
    }
}