upleb.uk

Public git repos — served from a NIP-34 GRASP relay at git.upleb.uk

summaryrefslogtreecommitdiff
path: root/tests/nip34_announcements.rs
blob: 6e83bb62b552f222ba08747a798e2771b5293a64 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
//! NIP-34 Repository Announcements Integration Tests (GRASP-01)
//!
//! Tests the acceptance and validation of repository announcements (kind 30617)
//! and repository state announcements (kind 30618) according to GRASP-01.
//!
//! Reference: GRASP-01, Lines 9-20
//!
//! # Test Strategy
//!
//! - Uses TestRelay fixture for automatic relay lifecycle management
//! - Pure Rust, no shell scripts
//! - Tests run in parallel with isolated relay instances
//!
//! # Running Tests
//!
//! ```bash
//! # Run all NIP-34 announcement tests
//! cargo test --test nip34_announcements
//!
//! # Run specific test
//! cargo test --test nip34_announcements test_accepts_valid_announcement
//!
//! # With output
//! cargo test --test nip34_announcements -- --nocapture
//! ```

mod common;

use common::TestRelay;
use futures_util::{SinkExt, StreamExt};
use nostr_sdk::{EventBuilder, Keys, Kind, Tag, TagKind};
use serde_json::{json, Value};
use tokio_tungstenite::{connect_async, tungstenite::Message};

const KIND_REPOSITORY_ANNOUNCEMENT: u16 = 30617;
const KIND_REPOSITORY_STATE: u16 = 30618;

/// Helper to connect to a test relay
async fn connect_to_relay(url: &str) -> tokio_tungstenite::WebSocketStream<tokio_tungstenite::MaybeTlsStream<tokio::net::TcpStream>> {
    let (ws, _) = connect_async(url)
        .await
        .expect("Failed to connect to relay");
    ws
}

/// Helper to create a repository announcement event
fn create_announcement(
    keys: &Keys,
    _domain: &str,
    identifier: &str,
    clone_urls: Vec<String>,
    relays: Vec<String>,
) -> nostr_sdk::Event {
    let mut tags = vec![Tag::custom(TagKind::d(), vec![identifier.to_string()])];

    for url in clone_urls {
        tags.push(Tag::custom(
            TagKind::Clone,
            vec![url],
        ));
    }

    for relay in relays {
        tags.push(Tag::custom(TagKind::Relays, vec![relay]));
    }

    EventBuilder::new(
        Kind::from(KIND_REPOSITORY_ANNOUNCEMENT),
        "Test repository description",
    )
    .tags(tags)
    .sign_with_keys(keys)
    .expect("Failed to sign event")
}

/// Helper to create a repository state event
fn create_state(keys: &Keys, identifier: &str, branches: Vec<(&str, &str)>) -> nostr_sdk::Event {
    let mut tags = vec![Tag::custom(TagKind::d(), vec![identifier.to_string()])];

    for (branch, commit) in branches {
        tags.push(Tag::custom(
            TagKind::Custom("ref".into()),
            vec![format!("refs/heads/{}", branch), commit.to_string()],
        ));
    }

    EventBuilder::new(Kind::from(KIND_REPOSITORY_STATE), "")
        .tags(tags)
        .sign_with_keys(keys)
        .expect("Failed to sign event")
}

/// GRASP-01, Line 9-10: MUST serve a NIP-01 compliant nostr relay at `/`
#[tokio::test]
async fn test_relay_accepts_connection() {
    let relay = TestRelay::start().await;
    
    // Try to connect
    let ws = connect_to_relay(relay.url()).await;
    
    drop(ws); // Clean disconnect
}

/// GRASP-01, Line 11: MUST accept repository announcements (kind 30617)
#[tokio::test]
async fn test_accepts_valid_announcement() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let mut ws = connect_to_relay(relay.url()).await;

    let event = create_announcement(
        &keys,
        &relay.domain(),
        "test-repo",
        vec![format!("https://{}/alice/test-repo.git", relay.domain())],
        vec![format!("wss://{}", relay.domain())],
    );

    // Send event
    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    // Read response
    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response: Value = serde_json::from_str(&text).expect("Failed to parse response");
        
        // Should be ["OK", event_id, true, ""]
        assert_eq!(response[0], "OK");
        assert_eq!(response[1], event.id.to_hex());
        if response[2] != true {
            eprintln!("Event rejected: {}", response[3]);
        }
        assert_eq!(response[2], true, "Event should be accepted");
    } else {
        panic!("No response received");
    }
}

/// GRASP-01, Line 12-13: MUST reject announcements that do not list the service
/// in both `clone` and `relays` tags
#[tokio::test]
async fn test_rejects_announcement_without_clone() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    // Missing clone tag
    let event = create_announcement(
        &keys,
        &relay.domain(),
        "test-repo",
        vec![], // No clone URLs
        vec![format!("wss://{}", relay.domain())],
    );

    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response: Value = serde_json::from_str(&text).expect("Failed to parse");
        
        // Should be rejected
        assert_eq!(response[0], "OK");
        assert_eq!(response[1], event.id.to_hex());
        assert_eq!(response[2], false, "Event should be rejected");
        
        let message = response[3].as_str().unwrap();
        assert!(
            message.contains("clone") || message.contains("invalid"),
            "Error message should mention clone requirement: {}",
            message
        );
    } else {
        panic!("No response received");
    }
}

/// GRASP-01, Line 12-13: MUST reject announcements that do not list the service
/// in both `clone` and `relays` tags
#[tokio::test]
async fn test_rejects_announcement_without_relay() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    // Missing relay tag
    let event = create_announcement(
        &keys,
        &relay.domain(),
        "test-repo",
        vec![format!("https://{}/alice/test-repo.git", relay.domain())],
        vec![], // No relays
    );

    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response: Value = serde_json::from_str(&text).expect("Failed to parse");
        
        // Should be rejected
        assert_eq!(response[0], "OK");
        assert_eq!(response[1], event.id.to_hex());
        assert_eq!(response[2], false, "Event should be rejected");
        
        let message = response[3].as_str().unwrap();
        assert!(
            message.contains("relays") || message.contains("invalid"),
            "Error message should mention relay requirement: {}",
            message
        );
    } else {
        panic!("No response received");
    }
}

/// GRASP-01, Line 12-13: MUST reject announcements listing other services
#[tokio::test]
async fn test_rejects_announcement_for_other_service() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    // Lists different service
    let event = create_announcement(
        &keys,
        &relay.domain(),
        "test-repo",
        vec!["https://other-service.com/alice/test-repo.git".to_string()],
        vec!["wss://other-service.com".to_string()],
    );

    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response: Value = serde_json::from_str(&text).expect("Failed to parse");
        
        // Should be rejected
        assert_eq!(response[0], "OK");
        assert_eq!(response[1], event.id.to_hex());
        assert_eq!(response[2], false, "Event should be rejected");
    } else {
        panic!("No response received");
    }
}

/// GRASP-01, Line 11: MUST accept repository state announcements (kind 30618)
#[tokio::test]
async fn test_accepts_valid_state() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    let event = create_state(
        &keys,
        "test-repo",
        vec![("main", "a1b2c3d4e5f6789012345678901234567890abcd")],
    );

    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response: Value = serde_json::from_str(&text).expect("Failed to parse");
        
        // Should be accepted
        assert_eq!(response[0], "OK");
        assert_eq!(response[1], event.id.to_hex());
        assert_eq!(response[2], true, "State event should be accepted");
    } else {
        panic!("No response received");
    }
}

/// Test state event with multiple branches
#[tokio::test]
async fn test_accepts_state_with_multiple_branches() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    let event = create_state(
        &keys,
        "test-repo",
        vec![
            ("main", "a1b2c3d4e5f6789012345678901234567890abcd"),
            ("develop", "b2c3d4e5f6789012345678901234567890abcde"),
            ("feature-x", "c3d4e5f6789012345678901234567890abcdef1"),
        ],
    );

    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response: Value = serde_json::from_str(&text).expect("Failed to parse");
        
        assert_eq!(response[0], "OK");
        assert_eq!(response[2], true, "State event should be accepted");
    } else {
        panic!("No response received");
    }
}

/// Test state event without identifier should be rejected
#[tokio::test]
async fn test_rejects_state_without_identifier() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    // Create state without identifier
    let event = EventBuilder::new(Kind::from(KIND_REPOSITORY_STATE), "")
        .sign_with_keys(&keys)
        .expect("Failed to sign event");

    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response: Value = serde_json::from_str(&text).expect("Failed to parse");
        
        // Should be rejected
        assert_eq!(response[0], "OK");
        assert_eq!(response[1], event.id.to_hex());
        assert_eq!(response[2], false, "Event should be rejected");
        
        let message = response[3].as_str().unwrap();
        assert!(
            message.contains("identifier") || message.contains("invalid"),
            "Error message should mention identifier requirement: {}",
            message
        );
    } else {
        panic!("No response received");
    }
}

/// Test querying for announcements
#[tokio::test]
async fn test_query_announcements() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    // Send an announcement
    let event = create_announcement(
        &keys,
        &relay.domain(),
        "query-test-repo",
        vec![format!("https://{}/alice/query-test-repo.git", relay.domain())],
        vec![format!("wss://{}", relay.domain())],
    );

    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    // Wait for OK response
    if let Some(Ok(Message::Text(_))) = ws.next().await {
        // Got OK response
    }

    // Query for announcements
    let req = json!([
        "REQ",
        "test-sub",
        {
            "kinds": [KIND_REPOSITORY_ANNOUNCEMENT],
            "authors": [keys.public_key().to_hex()]
        }
    ]);

    ws.send(Message::Text(req.to_string()))
        .await
        .expect("Failed to send REQ");

    // Read responses
    let mut found_event = false;
    let mut got_eose = false;

    for _ in 0..10 {
        if let Some(Ok(Message::Text(text))) = ws.next().await {
            let response: Value = serde_json::from_str(&text).expect("Failed to parse");
            
            if response[0] == "EVENT" {
                assert_eq!(response[1], "test-sub");
                found_event = true;
            } else if response[0] == "EOSE" {
                assert_eq!(response[1], "test-sub");
                got_eose = true;
                break;
            }
        }
    }

    assert!(found_event, "Should have received the announcement");
    assert!(got_eose, "Should have received EOSE");
}

/// Test querying for state events
#[tokio::test]
async fn test_query_states() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    // Send a state event
    let event = create_state(
        &keys,
        "query-test-repo",
        vec![("main", "a1b2c3d4e5f6789012345678901234567890abcd")],
    );

    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    // Wait for OK response
    if let Some(Ok(Message::Text(_))) = ws.next().await {
        // Got OK response
    }

    // Query for states
    let req = json!([
        "REQ",
        "test-sub",
        {
            "kinds": [KIND_REPOSITORY_STATE],
            "authors": [keys.public_key().to_hex()]
        }
    ]);

    ws.send(Message::Text(req.to_string()))
        .await
        .expect("Failed to send REQ");

    // Read responses
    let mut found_event = false;
    let mut got_eose = false;

    for _ in 0..10 {
        if let Some(Ok(Message::Text(text))) = ws.next().await {
            let response: Value = serde_json::from_str(&text).expect("Failed to parse");
            
            if response[0] == "EVENT" {
                assert_eq!(response[1], "test-sub");
                found_event = true;
            } else if response[0] == "EOSE" {
                assert_eq!(response[1], "test-sub");
                got_eose = true;
                break;
            }
        }
    }

    assert!(found_event, "Should have received the state event");
    assert!(got_eose, "Should have received EOSE");
}

/// Test duplicate event handling
#[tokio::test]
async fn test_duplicate_announcement() {
    let relay = TestRelay::start().await;
    let keys = Keys::generate();

    let (mut ws, _) = connect_async(relay.url())
        .await
        .expect("Failed to connect");

    let event = create_announcement(
        &keys,
        &relay.domain(),
        "duplicate-test",
        vec![format!("https://{}/alice/duplicate-test.git", relay.domain())],
        vec![format!("wss://{}", relay.domain())],
    );

    // Send first time
    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response1: Value = serde_json::from_str(&text).expect("Failed to parse");
        assert_eq!(response1[2], true, "First send should succeed");
    }

    // Send second time (duplicate)
    let event_msg = json!(["EVENT", event]);
    ws.send(Message::Text(event_msg.to_string()))
        .await
        .expect("Failed to send event");

    if let Some(Ok(Message::Text(text))) = ws.next().await {
        let response2: Value = serde_json::from_str(&text).expect("Failed to parse");
        assert_eq!(response2[2], true, "Duplicate should be acknowledged");
        
        let message = response2[3].as_str().unwrap();
        assert!(
            message.contains("duplicate") || message.is_empty(),
            "Should indicate duplicate: {}",
            message
        );
    }
}